Merge lp:~maxolasersquad/ubuntu/precise/epiphany-browser/add_quicklist into lp:ubuntu/precise/epiphany-browser

[David Baucum]

Adds a Unity Quicklist shortcut to Epiphany's launcher for opening new instances of the browser.

[Sebastien Bacher (seb128)]

Thank you for your work, could you send it upstream on https://bugzilla.gnome.org/enter_bug.cgi

We can't translate universe sources easily and it's late in the cycle so better to get that upstream first

I'm setting the merge request to "in progress" to get it out of the sponsoring queue for now since we will not upload it before precise

Note that to be consistent with other entries you might want to use "Open New Window" and "Open New Window in Private Mode"

review: Needs Fixing

[David Baucum (maxolasersquad)]

> Thank you for your work, could you send it upstream on
> https://bugzilla.gnome.org/enter_bug.cgi
>
> We can't translate universe sources easily and it's late in the cycle so
> better to get that upstream first
>
> I'm setting the merge request to "in progress" to get it out of the sponsoring
> queue for now since we will not upload it before precise
>
> Note that to be consistent with other entries you might want to use "Open New
> Window" and "Open New Window in Private Mode"

I will send it upstream.

When you say to be consistent, what is the wording you propose consistent with? In Chromium the verbiage is "Open a New Window" and "Open a New Window in incognito mode" and in Firefox the verbiage is "Open a New Window" It was based on the verbiage used in these other two browsers that I chose the verbiage in this commit.

[lp:~maxolasersquad/ubuntu/precise/epiphany-browser/add_quicklist]

120. By David Baucum on 2012-02-28

Fixed command to launch private browsing from the unity quicklist.

[Sebastien Bacher (seb128)]

It seems we have a bit on an inconsistance already there with the use of "a" or not indeed, I've no strong opinion either way, the designer I asked to recommended using whatever the application is using in its menu but seems the most frequent form is "Open New Something"

[Sebastien Bacher (seb128)]

Could you update to use the new Desktop Action format?

the Name should be prefixed by a "_", i.e _Name to be translatable

"Open a New Window in private mode" should also be "Open a New Window in Private Mode"

[lp:~maxolasersquad/ubuntu/precise/epiphany-browser/add_quicklist]

121. By David Baucum on 2012-03-20

Changed Unity Quicklist to use the freedesktop.org specification

122. By David Baucum on 2012-03-20

Fixed quicklist integration target

Unmerged revisions

122. By David Baucum on 2012-03-20

Fixed quicklist integration target

121. By David Baucum on 2012-03-20

Changed Unity Quicklist to use the freedesktop.org specification

120. By David Baucum on 2012-02-28

Fixed command to launch private browsing from the unity quicklist.

119. By David Baucum on 2012-02-25

Add a Unity Quicklist

=== modified file 'data/epiphany.desktop.in.in'
--- data/epiphany.desktop.in.in	2012-01-25 16:55:38 +0000
+++ data/epiphany.desktop.in.in	2012-03-20 04:25:19 +0000
@@ -14,3 +14,15 @@
 X-GNOME-Bugzilla-Version=@VERSION@
 Categories=Network;GNOME;GTK;WebBrowser;
 MimeType=text/html;text/xml;application/xhtml+xml;x-scheme-handler/http;x-scheme-handler/https;
+
+Actions=NewWindow;PrivateWindow
+
+[Desktop Action NewWindow]
+_Name=Open a New Window
+Exec=epiphany --new-window
+OnlyShowIn=Unity
+
+[Desktop Action PrivateWindow]
+_Name=Open a New Window in private mode
+Exec=epiphany --private-instance
+OnlyShowIn=Unity