Ubuntu

Merge lp:~maxolasersquad/ubuntu/precise/brasero/add_quicklist into lp:ubuntu/precise/brasero

Proposed by David Baucum on 2012-02-22
Status: Merged
Merge reported by: Michael Terry
Merged at revision: not available
Proposed branch: lp:~maxolasersquad/ubuntu/precise/brasero/add_quicklist
Merge into: lp:ubuntu/precise/brasero
Diff against target: 93 lines (+73/-1) 2 files modified
To merge this branch: bzr merge lp:~maxolasersquad/ubuntu/precise/brasero/add_quicklist
Reviewer Review Type Date Requested Status
Ubuntu branches 2012-02-22 Pending
Review via email: mp+94202@code.launchpad.net

Description of the Change

Adds a Unity Quicklist shortcut to Brasero's launcher for opening new instances of the burner.

To post a comment you must log in.
97. By David Baucum on 2012-02-22

Renamed some quicklist options and added others.

98. By David Baucum on 2012-02-22

Replicated changes to .in.in desktop file.

Michael Hall (mhall119) wrote :

Thanks so much for your submission!

Recently a new FreeDesktop.org specification[1] has been approved for providing desktop-agnostic shortcuts. The Quicklist documentation has been updated to coincide with this new spec[2].

Since this is now an official standard, and will benefit environments other than Unity, we encourage you to change your code to match. This will require the following changes:
1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
2) Change each section from "[<action> Shortcut Group]" to "[Desktop Action <action>]"
3) Remove "TargetEnvironment=Unity"
4) Change your Name= entry to use Title Case[3] (capitalizing important words)

Please update this merge proposal with these changes so they can be included in the upcoming release of Ubuntu. Please also make sure you submit them to the upstream developers so they can be included there in future versions.

[1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
[2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
[3] http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles

David Baucum (maxolasersquad) wrote :

You know, someone gave push back regarding the spec, and I read it and
became rather confused because I was pretty sure the way I did it first was
according to spec. I'll go through and update accordingly.

On Tue, Feb 28, 2012 at 4:45 PM, Michael Hall <email address hidden> wrote:

> Thanks so much for your submission!
>
> Recently a new FreeDesktop.org specification[1] has been approved for
> providing desktop-agnostic shortcuts. The Quicklist documentation has been
> updated to coincide with this new spec[2].
>
> Since this is now an official standard, and will benefit environments
> other than Unity, we encourage you to change your code to match. This will
> require the following changes:
> 1) Change "X-Ayatana-Desktop-Shortcuts" to just "Actions"
> 2) Change each section from "[<action> Shortcut Group]" to "[Desktop
> Action <action>]"
> 3) Remove "TargetEnvironment=Unity"
> 4) Change your Name= entry to use Title Case[3] (capitalizing important
> words)
>
> Please update this merge proposal with these changes so they can be
> included in the upcoming release of Ubuntu. Please also make sure you
> submit them to the upstream developers so they can be included there in
> future versions.
>
> [1]
> http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s08.html
> [2] https://wiki.ubuntu.com/Unity/LauncherAPI#Quicklists
> [3]
> http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles
>
> --
>
> https://code.launchpad.net/~maxolasersquad/ubuntu/precise/brasero/add_quicklist/+merge/94202
> You are the owner of
> lp:~maxolasersquad/ubuntu/precise/brasero/add_quicklist.
>

--
    Jack David Baucum
    http://maxolasersquad.com

Michael Terry (mterry) wrote :

A similar branch got merged (https://code.launchpad.net/~nik90/ubuntu/precise/brasero/add_quicklist/+merge/94206), but they both did the same thing. I'm just marking this one as Merged too, to drop it from reviewers' radar.

Preview Diff

1=== modified file 'data/brasero.desktop.in'
2--- data/brasero.desktop.in 2011-09-27 15:37:40 +0000
3+++ data/brasero.desktop.in 2012-02-22 16:21:23 +0000
4@@ -1,4 +1,4 @@
5-[Desktop Entry]
6+[Desktop]
7 _Name=Brasero
8 _GenericName=Disc Burner and Copier
9 _Comment=Create and copy CDs and DVDs
10@@ -14,3 +14,39 @@
11 X-GNOME-Bugzilla-Product=brasero
12 X-GNOME-Bugzilla-Component=general
13 X-GNOME-Bugzilla-Version=3.2.0
14+
15+X-Ayatana-Desktop-Shotcuts=Screen;Window
16+[BurnAudio Shortcut Group]
17+Name=Create a new audio project
18+Exec=brasero -a
19+TargetEnvironment=Unity
20+
21+X-Ayatana-Desktop-Shotcuts=Screen;Window
22+[BurnData Shortcut Group]
23+Name=Create a new data project
24+Exec=brasero -d
25+TargetEnvironment=Unity
26+
27+X-Ayatana-Desktop-Shotcuts=Screen;Window
28+[BurnVideo Shortcut Group]
29+Name=Create a new video project
30+Exec=brasero -o
31+TargetEnvironment=Unity
32+
33+X-Ayatana-Desktop-Shotcuts=Screen;Window
34+[BurnImage Shortcut Group]
35+Name=Burn an image file
36+Exec=brasero -k
37+TargetEnvironment=Unity
38+
39+X-Ayatana-Desktop-Shotcuts=Screen;Window
40+[Copy Disk Shortcut Group]
41+Name=Copy a disc
42+Exec=brasero -c
43+TargetEnvironment=Unity
44+
45+X-Ayatana-Desktop-Shotcuts=Screen;Window
46+[CheckDisk Shortcut Group]
47+Name=Check disk
48+Exec=brasero -k
49+TargetEnvironment=Unity
50
51=== modified file 'data/brasero.desktop.in.in'
52--- data/brasero.desktop.in.in 2011-05-18 17:53:39 +0000
53+++ data/brasero.desktop.in.in 2012-02-22 16:21:23 +0000
54@@ -14,3 +14,39 @@
55 X-GNOME-Bugzilla-Product=brasero
56 X-GNOME-Bugzilla-Component=general
57 X-GNOME-Bugzilla-Version=@VERSION@
58+
59+X-Ayatana-Desktop-Shotcuts=Screen;Window
60+[BurnAudio Shortcut Group]
61+Name=Create a new audio project
62+Exec=brasero -a
63+TargetEnvironment=Unity
64+
65+X-Ayatana-Desktop-Shotcuts=Screen;Window
66+[BurnData Shortcut Group]
67+Name=Create a new data project
68+Exec=brasero -d
69+TargetEnvironment=Unity
70+
71+X-Ayatana-Desktop-Shotcuts=Screen;Window
72+[BurnVideo Shortcut Group]
73+Name=Create a new video project
74+Exec=brasero -o
75+TargetEnvironment=Unity
76+
77+X-Ayatana-Desktop-Shotcuts=Screen;Window
78+[BurnImage Shortcut Group]
79+Name=Burn an image file
80+Exec=brasero -k
81+TargetEnvironment=Unity
82+
83+X-Ayatana-Desktop-Shotcuts=Screen;Window
84+[Copy Disk Shortcut Group]
85+Name=Copy a disc
86+Exec=brasero -c
87+TargetEnvironment=Unity
88+
89+X-Ayatana-Desktop-Shotcuts=Screen;Window
90+[CheckDisk Shortcut Group]
91+Name=Check disk
92+Exec=brasero -k
93+TargetEnvironment=Unity

Subscribers

People subscribed via source and target branches

to all changes: