maxima:rtoy-refactor-specvars-defint-var-method-by-limits

Last commit made on 2024-01-21
Get this branch:
git clone -b rtoy-refactor-specvars-defint-var-method-by-limits https://git.launchpad.net/maxima

Branch merges

Branch information

Name:
rtoy-refactor-specvars-defint-var-method-by-limits
Repository:
lp:maxima

Recent commits

155bb15... by Raymond Toy <email address hidden>

Bind var for plog in ztorat

The simplifier for plog references the specvar `var` and it's
important to do the binding here in the call to `keyhole` in `ztorat`.
I guess the intent is to prevent the simplifier from converting
plog(-x) to log(x)+%i*%pi when x > 0, as happens in `ztorat`.

Full testsuite + share tests pass with cmucl.

258b4f5... by Raymond Toy <email address hidden>

Bind var for plog in ztorat

In `ztorat`, we multiply the numerator by plog(-x). In doing so, we
end up calling the plog simplifier that references `var`:

```
    ((among var x) ;This is used in DEFINT. 1/19/81. -JIM
     (return (give-up))))
```

Thus, we need to bind `var` before calling the simplifier for plog.
This is important. Without this, we get failures in the testsuite.
With this, there's no problem.

More debugging needed.

94f2b4b... by Raymond Toy <email address hidden>

Rename var to ivar in method-by-limits

However, to pass the testsuite we need to bind `var` before calling
`keyhole` in `ztorat`.

This needs further debugging.

f09ead6... by Raymond Toy <email address hidden>

Revert changes that added bindings of var

Basically undo the changes we done on this branch during debugging of
the renaming of `var` in `method-by-limits`.

The branch `rtoy-refactor-specvars-defint-var` basically works when we
rename `var`, with just one additional binding of `var`.

10a64c6... by Raymond Toy <email address hidden>

Merge branch 'rtoy-refactor-specvars-defint-var' into rtoy-refactor-specvars-defint-var-method-by-limits

a9e31fd... by Raymond Toy <email address hidden>

Remove accidental binding of var in ztorat

We accidentally adding a binding for `var` around the call to
`keyhole` in `ztorat`. It's not needed right now.

Full testsuite + share passes with cmucl.

78c37e2... by Raymond Toy <email address hidden>

Add replacement for polyp that refs specvar var

The function `polyp` references the special var `var` so we add a
replacement `polyp-var` that takes an extra arg, `ivar`, and binds
`var` to it before calling `res`. This is a workaround until we fix
`polyp` to make the dependency explicit.

Update all uses of `polyp`.

Full testsuite + share passes with cmucl.

10f77b8... by Raymond Toy <email address hidden>

Add replacement for res1 that refs specvar var

The function `res1` references the special var `var` so we add a
replacement `res1-var` that takes an extra arg, `ivar`, and binds
`var` to it before calling `res`. This is a workaround until we fix
`res1` to make the dependency explicit.

Update all uses of `res1`.

Full testsuite + share passes with cmucl.

b5a9477... by Raymond Toy <email address hidden>

Merge branch 'rtoy-refactor-specvars-defint-var' into rtoy-refactor-specvars-defint-var-method-by-limits

b2878ff... by Raymond Toy <email address hidden>

Add replacement for deg that refs specvar var

The function `deg` references the special var `var` so we add a
replacement `deg-var` that takes an extra arg, `ivar`, and binds
`var` to it before calling `deg`. This is a workaround until we fix
`deg` to make the dependency explicit.

Update all uses of `deg`. This requires passing in `ivar` in
`difapply` and `diffhk`. Update all callers appropriately.

Full testsuite + share passes with cmucl.