maxima:rtoy-refactor-ratout-specvar-x

Last commit made on 2023-02-21
Get this branch:
git clone -b rtoy-refactor-ratout-specvar-x https://git.launchpad.net/maxima

Branch merges

Branch information

Name:
rtoy-refactor-ratout-specvar-x
Repository:
lp:maxima

Recent commits

60423bb... by Raymond Toy <email address hidden>

Fix typo in $partfrac

A stray "n" got introduced that shouldn't be there.

f7baf54... by Raymond Toy <email address hidden>

Reindent ratout.lisp

Just indent some things a bit more neatly.

No functional changes.

d29a84b... by Raymond Toy <email address hidden>

Rename x to ratout-x for consistency

Even though these uses of `x` aren't supposed to be special vars,
lets' rename them all anyway for consistency and also to make sure
some other file doesn't declare `x` as a special and inadvertently
make these `x`'s special.

Full testsuite passes.

00dfde9... by Raymond Toy <email address hidden>

Remove x from declare-top

There are no uses of `x` anymore after the first declaration of `x` as
a special. Thus we can remove the commented out (redundant) special
declaration near line 790. We can also remove the `unspecial`
declaration for `x` because there are no uses of `x` afterwards.

Full testsuite passes.

b60507b... by Raymond Toy <email address hidden>

Comment out sssqfr and pfet1

Since we commented out `$pfet`, we can comment out `sssqfr` and
`pfet1` because they are only called from `$pfet`.

61a79e8... by Raymond Toy <email address hidden>

Rename x to ratout-x in $ratdiff

`$ratdiff` doesn't really seem to need the special variable `x`, so
rename it to `ratout-x`.

Remove the special declaration for `x` too that occurs just before
`$ratdiff`. (Note the there's another declaration for `x` near the
beginning of the file.)

Full testsuite passes.

8333177... by Raymond Toy <email address hidden>

Merge branch 'master' into rtoy-refactor-ratout-specvar-xv-gcd

7fa40d9... by Raymond Toy <email address hidden>

Manually revert cde0c181

Commit [cde0c181] updated dependencies for risch.lisp to get `dosum`
and `mtoa` (at least) to be compiled before risch.lisp. However, this
causes test failures with ecl. I just did a git bisect to find that
[cde0c181] is the first bad commit.

I didn't investigate why this causes test failures. I'm guessing some
of the files declare a variable special, which also happens to be the
name of some variable in risch.lisp, so things are messed up. (If so,
this is yet another reason to remove as many special variables as
possible.)

Reverting the commit manually allows ecl to pass the testsuite without
errors, as expected.

cd7de55... by Raymond Toy <email address hidden>

Move comments pmodcontent and remove it's defn

We moved `pmodcontent` into `pgcdp` but left the original commented
out. Remove that function now, and move the corresponding comment to
the labels function.

7b414e9... by Robert Dodier <email address hidden>

In package descriptive, implementation of "skyline histogram",
which is just showing the outline of the histogram bars, instead of drawing
all the vertical segments.

histogram and histogram_description construct skyline histograms when
the global variable histogram_skyline = true (false by default).