Launchpad itself

Merge lp:~maxiberta/launchpad/sitesearch-cleanup-2 into lp:launchpad

  1. sitesearch-cleanup-2
  2. Merge into devel
Proposed by Maximiliano Bertacchini
Status: Merged
Merged at revision: 18624
Proposed branch: lp:~maxiberta/launchpad/sitesearch-cleanup-2
Merge into: lp:launchpad
Prerequisite: lp:~maxiberta/launchpad/sitesearch-cleanup-1
Diff against target: 0 lines
To merge this branch: bzr merge lp:~maxiberta/launchpad/sitesearch-cleanup-2
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+343236@code.launchpad.net

Commit message

Add sitesearch tests based on doctests.

Description of the change

Add sitesearch tests based on doctests.
- sitesearch/doc/google-searchservice.txt => sitesearch/tests/test_google.py
- sitesearch/doc/bing-searchservice.txt => sitesearch/tests/test_bing.py

Add PageMatch and PageMatches unittests based on doctests.
  - sitesearch/doc/*-searchservice.txt => sitesearch/tests/test_pagematch.py

Drop all sitesearch doctests (lib/lp/sitesearch/doc).

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Most of these comments apply in multiple places, but I've only commented on the first occurrence of each.

review: Approve
Revision history for this message
Colin Watson (cjwatson) wrote :

Also, did you intend to remove the corresponding doctests at the same time? They still seem to be in this tree.

Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

All comments addressed. Was unsure about deleting those doctests or keeping them for documentation purposes. Also, there's an extra disabled doctest, which I think I could tackle in this same branch. What do you think?

Preview Diff

Empty