Merge lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad

Proposed by Maximiliano Bertacchini
Status: Merged
Merged at revision: 18561
Proposed branch: lp:~maxiberta/launchpad/lp-1729580-2
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/snappy/templates/snapbuild-index.pt (+1/-1)
To merge this branch: bzr merge lp:~maxiberta/launchpad/lp-1729580-2
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+338562@code.launchpad.net

Commit message

Use target="_blank" in extended snap build error links.

Description of the change

Use target="_blank" in extended snap build error links. Fixes browsers refusing to load external links due to "X-Frame-Options: sameorigin".

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/snappy/templates/snapbuild-index.pt'
2--- lib/lp/snappy/templates/snapbuild-index.pt 2018-02-19 17:51:30 +0000
3+++ lib/lp/snappy/templates/snapbuild-index.pt 2018-02-22 15:53:34 +0000
4@@ -185,7 +185,7 @@
5 <span tal:replace="error/message"/>
6 <a tal:condition="error/link"
7 tal:attributes="href error/link"
8- target="help"
9+ target="_blank"
10 class="sprite maybe action-icon">(?)</a>
11 </li>
12 </ul>