Merge lp:~maxiberta/django-openid-auth/fix-logo-view into lp:django-openid-auth
Proposed by
Maximiliano Bertacchini
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Maximiliano Bertacchini | ||||
Approved revision: | 130 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~maxiberta/django-openid-auth/fix-logo-view | ||||
Merge into: | lp:django-openid-auth | ||||
Diff against target: |
10 lines (+1/-1) 1 file modified
django_openid_auth/views.py (+1/-1) |
||||
To merge this branch: | bzr merge lp:~maxiberta/django-openid-auth/fix-logo-view | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+353710@code.launchpad.net |
Commit message
Fix logo view to support Django>=1.7.
Description of the change
This should not affect backward compatibility, as the `content_type` argument to the HttpResponse constructor was added in Django==1.0 [0] as an alias to `mimetype`, which was deprecated in Django==1.5, and removed in Django==1.7 [1].
[0] https:/
[1] https:/
To post a comment you must log in.
Hahaha, talk about old code.
Thanks for going broken- window- fixing on this tiny but annoying bug!
https:/ /en.wikipedia. org/wiki/ Broken_ windows_ theory