Merge lp:~maxiberta/canonical-identity-provider/smarter-forget-password-link into lp:canonical-identity-provider/release
Proposed by
Maximiliano Bertacchini
Status: | Merged |
---|---|
Approved by: | Maximiliano Bertacchini |
Approved revision: | no longer in the source branch. |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | lp:~maxiberta/canonical-identity-provider/smarter-forget-password-link |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
143 lines (+34/-22) 7 files modified
src/identityprovider/tests/openid_server/per_version/test_sso_workflow_reset_password.py (+6/-9) src/identityprovider/tests/sso_server/test_prefilled_email.py (+5/-4) src/webui/templates/common/forgot_password_link.html (+0/-5) src/webui/templates/registration/_login_form.html (+5/-1) src/webui/templates/registration/login.html (+1/-1) src/webui/tests/test_views_registration.py (+14/-0) src/webui/views/registration.py (+3/-2) |
To merge this branch: | bzr merge lp:~maxiberta/canonical-identity-provider/smarter-forget-password-link |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tom Wardill (community) | Approve | ||
Review via email: mp+361579@code.launchpad.net |
Commit message
Pre-fill forgot password form with email value entered in the login form.
To post a comment you must log in.
Some notes:
- Turned login's "Forgot your password?" into <input> so that it can POST the current value of the email field.
- The new <input> link has the "formnovalidate" attribute set to skip client-side form validations, e.g. non-empty password. Thus whatever value is currently set in the email field is POSTed to and validated by the forgot-password view.
- The new <input> link has the "formaction" attribute defined to make its destination URL more explicit and easier to test.
- The new <input> link has some css magic to make it look like an <a>.