Merge lp:~maxiberta/canonical-identity-provider/recent-sites-left-align-date into lp:canonical-identity-provider/release

Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Maximiliano Bertacchini
Approved revision: no longer in the source branch.
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~maxiberta/canonical-identity-provider/recent-sites-left-align-date
Merge into: lp:canonical-identity-provider/release
Diff against target: 23 lines (+3/-3)
1 file modified
src/webui/templates/widgets/last_auth_sites.html (+3/-3)
To merge this branch: bzr merge lp:~maxiberta/canonical-identity-provider/recent-sites-left-align-date
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+379485@code.launchpad.net

Commit message

Left align recent login date.

Additionally, split column width at 75% / 25% so that dates are not too close to sites. Looks good in mobile, too.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, no logical rationale was provided for left-aligning dates but this is a minor tweak so no objections.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webui/templates/widgets/last_auth_sites.html'
2--- src/webui/templates/widgets/last_auth_sites.html 2020-02-11 10:04:13 +0000
3+++ src/webui/templates/widgets/last_auth_sites.html 2020-02-19 16:04:11 +0000
4@@ -13,8 +13,8 @@
5 <table class="p-table">
6 <thead>
7 <tr>
8- <th>Site</th>
9- <th class="u-align--right">Date</th>
10+ <th style="width: 75%;">Site</th>
11+ <th>Date</th>
12 </tr>
13 </thead>
14 <tbody>
15@@ -24,7 +24,7 @@
16 {% if embedded %}{{ site.trust_root }}{% else %}
17 <a href="{{ site.trust_root }}" data-qa-id="visited_site_url">{{ site.trust_root }}</a>{% endif %}
18 </td>
19- <td class="u-align--right" data-qa-id="visited_site_date">
20+ <td data-qa-id="visited_site_date">
21 {{ site.date_last_used|date:"Y/m/d" }}
22 </td>
23 </tr>