Merge lp:~maxiberta/canonical-identity-provider/openid-session-ttl into lp:canonical-identity-provider/release
Proposed by
Maximiliano Bertacchini
Status: | Merged |
---|---|
Approved by: | Maximiliano Bertacchini |
Approved revision: | no longer in the source branch. |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | lp:~maxiberta/canonical-identity-provider/openid-session-ttl |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
300 lines (+165/-2) 3 files modified
django_project/settings_base.py (+1/-0) src/identityprovider/tests/test_views_server.py (+130/-1) src/identityprovider/views/server.py (+34/-1) |
To merge this branch: | bzr merge lp:~maxiberta/canonical-identity-provider/openid-session-ttl |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+354127@code.launchpad.net |
Commit message
Expire old OpenID tokens from user sessions.
Description of the change
Tracks openid token expiration in each session (session[
To post a comment you must log in.
LGTM, my only nitpick is that 24 * 60 * 60 is harder for me to read than 86400, a well-known constant for "seconds in a day". But I acknowledge the 24 * 60 * 60 variant is widely used in this codebase, so let's keep it for consistency.