Merge lp:~maxiberta/canonical-identity-provider/full-name-instead-of-your-name into lp:canonical-identity-provider/release

Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Maximiliano Bertacchini
Approved revision: no longer in the source branch.
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~maxiberta/canonical-identity-provider/full-name-instead-of-your-name
Merge into: lp:canonical-identity-provider/release
Diff against target: 12 lines (+1/-1)
1 file modified
src/webui/templates/account/edit.html (+1/-1)
To merge this branch: bzr merge lp:~maxiberta/canonical-identity-provider/full-name-instead-of-your-name
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+351883@code.launchpad.net

Commit message

Replace 'Your name:' by 'Full name:' to be consistent with the Snap Store dashboard(s).

Description of the change

Replace 'Your name:' by 'Full name:' to be consistent with the Snap Store dashboard(s).

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webui/templates/account/edit.html'
2--- src/webui/templates/account/edit.html 2017-02-26 13:25:21 +0000
3+++ src/webui/templates/account/edit.html 2018-07-31 16:08:33 +0000
4@@ -49,7 +49,7 @@
5 <div data-qa-id="personal_details"></div>
6
7 <div class="{% if form.displayname.errors %}haserrors {% endif %}name-input input-row">
8- <label class="formLabel" for="id_displayname">{% trans "Your name:" %}</label>
9+ <label class="formLabel" for="id_displayname">{% trans "Full name:" %}</label>
10 {{ form.displayname }}
11 {% if form.displayname.errors %}
12 <span class="error">