Merge lp:~maxiberta/canonical-identity-provider/drop_honeypot_from_delete_account into lp:canonical-identity-provider/release
Proposed by
Maximiliano Bertacchini
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Maximiliano Bertacchini | ||||
Approved revision: | no longer in the source branch. | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~maxiberta/canonical-identity-provider/drop_honeypot_from_delete_account | ||||
Merge into: | lp:canonical-identity-provider/release | ||||
Diff against target: |
56 lines (+19/-3) 2 files modified
src/identityprovider/middleware/honeypot.py (+1/-1) src/identityprovider/tests/test_middleware.py (+18/-2) |
||||
To merge this branch: | bzr merge lp:~maxiberta/canonical-identity-provider/drop_honeypot_from_delete_account | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+369777@code.launchpad.net |
Commit message
Exclude the delete account view from honeypot checks.
Description of the change
This fixes account deletion on browsers with overeager/buggy password managers (such as Chrome/Chromium). The web form still includes the honeypot field ("openid.
The affected URL: /+delete.
Additionally, fixed `HoneypotWhitel
To post a comment you must log in.
LGTM, thanks!