Canonical SSO provider

Merge lp:~maxiberta/canonical-identity-provider/drop-unused-terms into lp:canonical-identity-provider/release

  1. drop-unused-terms
  2. Merge into trunk
Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Maximiliano Bertacchini
Approved revision: no longer in the source branch.
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~maxiberta/canonical-identity-provider/drop-unused-terms
Merge into: lp:canonical-identity-provider/release
Diff against target: 21 lines (+0/-6)
1 file modified
src/webui/urls.py (+0/-6)
To merge this branch: bzr merge lp:~maxiberta/canonical-identity-provider/drop-unused-terms
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+379472@code.launchpad.net

Commit message

Drop unused terms views.

Description of the change

Awaiting confirmation that the dropped view is not in use: https://portal.admin.canonical.com/C124295/

UPDATE: got sso prod logs for the last ~6 months (starting on 2019-06-27). Only 6 hits to /terms/embedded/, 4 of which was probably me (Firefox 74 on linux), and 2 have a "mail.ru Bot" UA. So, I believe it is safe to drop this endpoint.

https://pastebin.canonical.com/p/Q7zHjzhj7P/

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

bye bye terms

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed directory 'src/webui/templates/static/terms'
2=== removed file 'src/webui/templates/static/terms.html'
3=== removed file 'src/webui/templates/static/terms/_terms_nav.html'
4=== removed file 'src/webui/templates/static/terms/_terms_text.html'
5=== removed file 'src/webui/templates/static/terms_embedded.html'
6=== modified file 'src/webui/urls.py'
7--- src/webui/urls.py 2018-08-24 15:31:13 +0000
8+++ src/webui/urls.py 2020-02-19 14:35:56 +0000
9@@ -130,12 +130,6 @@
10 name='one-redirect'),
11 url(r'^terms/$', RedirectView.as_view(url=settings.TERMS_OF_SERVICE_URL),
12 name='terms_and_conditions'),
13- # XXX cjwatson 2018-05-23: Is this still used? If so, we need an
14- # embedded-themed version of this page on the legal site that we can
15- # redirect to.
16- url(r'^terms/embedded/$', static_page,
17- {'page_name': 'terms_embedded.html'},
18- name='terms_and_conditions_embedded'),
19 url(r'^privacy/$', RedirectView.as_view(url=settings.PRIVACY_POLICY_URL),
20 name='privacy_policy'),
21 url(r'^privacy-notice/$',