Merge lp:~maxiberta/canonical-identity-provider/charm-add-openid-session-limit into lp:~ubuntuone-pqm-team/canonical-identity-provider/charm

Proposed by Maximiliano Bertacchini
Status: Merged
Approved by: Daniel Manrique
Approved revision: 90
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~maxiberta/canonical-identity-provider/charm-add-openid-session-limit
Merge into: lp:~ubuntuone-pqm-team/canonical-identity-provider/charm
Diff against target: 28 lines (+7/-0)
2 files modified
config.yaml (+4/-0)
templates/settings.py.j2 (+3/-0)
To merge this branch: bzr merge lp:~maxiberta/canonical-identity-provider/charm-add-openid-session-limit
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+373280@code.launchpad.net

Commit message

Add openid_token_limit option (if set, overrides the project's settings.OPENID_TOKEN_LIMIT).

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1 hohoho

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2019-04-18 20:09:21 +0000
3+++ config.yaml 2019-09-26 20:47:01 +0000
4@@ -257,6 +257,10 @@
5 type: string
6 default: "noreply@ubuntu.com"
7 description: "Sender address for SSO-originated emails (password resets, email validation, etc)."
8+ openid_token_limit:
9+ type: int
10+ default: 10
11+ description: "Max number of OpenID tokens allowed in a user session."
12 openid_token_ttl:
13 type: int
14 default: 86400
15
16=== modified file 'templates/settings.py.j2'
17--- templates/settings.py.j2 2019-04-19 10:59:33 +0000
18+++ templates/settings.py.j2 2019-09-26 20:47:01 +0000
19@@ -99,6 +99,9 @@
20 OOPSES['template']['reporter'] = '{{ oops_reporter }}'
21 OPENID_LAUNCHPAD_STAFF_TEAMS = {{ openid_launchpad_staff_teams }}
22 OPENID_LAUNCHPAD_TEAMS_MAPPING = {{ openid_launchpad_teams_mapping }}
23+{% if openid_token_limit %}
24+OPENID_TOKEN_LIMIT = {{ openid_token_limit }}
25+{% endif %}
26 {% if openid_token_ttl %}
27 OPENID_TOKEN_TTL = {{ openid_token_ttl }}
28 {% endif %}

Subscribers

People subscribed via source and target branches