Merge ~maxgmr/ubuntu/+source/rust-ognibuild:merge-lp2136182 into ubuntu/+source/rust-ognibuild:ubuntu/devel

Proposed by Max Gilmour
Status: Merged
Merge reported by: Max Gilmour
Merged at revision: e3fd9bc73e93c09b2883ad33d6b22c07a231f00f
Proposed branch: ~maxgmr/ubuntu/+source/rust-ognibuild:merge-lp2136182
Merge into: ubuntu/+source/rust-ognibuild:ubuntu/devel
Diff against target: 77 lines (+24/-12)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/disable-broken-tests (+15/-11)
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
Review via email: mp+497722@code.launchpad.net

Description of the change

This fixes LP: #2136182. The autopkgtests were failing because one of the unit tests opens a socket, which isn't available in the restricted autopkgtest environment.

I addressed this by disabling this test, just like the other two tests that open sockets, which were disabled earlier.

PPA: https://launchpad.net/~maxgmr/+archive/ubuntu/resolute-merges/+packages?field.name_filter=rust-ognibuild&field.status_filter=published&field.series_filter=

Passing amd64 autopkgtest log: https://autopkgtest.ubuntu.com/results/autopkgtest-resolute-maxgmr-resolute-merges/resolute/amd64/r/rust-ognibuild/20251217_201005_faf9f@/log.gz

Lintian:
W: rust-ognibuild source: missing-debian-watch-file-standard [debian/watch]
W: rust-ognibuild source: patch-file-present-but-not-mentioned-in-series [debian/patches/bump-tempfile]
W: rust-ognibuild source: patch-file-present-but-not-mentioned-in-series [debian/patches/debian-analyzer-0.160.5.patch]
W: rust-ognibuild source: patch-file-present-but-not-mentioned-in-series [debian/patches/disable-oversensitive-test]
W: rust-ognibuild source: patch-file-present-but-not-mentioned-in-series ... use "--tag-display-limit 0" to see all (or pipe to a file/program)

To post a comment you must log in.
Revision history for this message
Max Gilmour (maxgmr) wrote :

The updated patch has been forwarded to Debian here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1123556

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thanks, I'm uploading this for you to Debian and we'll sync it over.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 735c155..8790706 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+rust-ognibuild (0.2.6-1ubuntu1) resolute; urgency=medium
7+
8+ * d/p/disable-broken-tests: (LP: #2136182) Disable test which tries to open
9+ socket
10+
11+ -- Max Gilmour <max.gilmour@canonical.com> Tue, 16 Dec 2025 10:48:40 -0800
12+
13 rust-ognibuild (0.2.6-1) unstable; urgency=medium
14
15 * Package ognibuild 0.2.6 from crates.io using debcargo 2.7.11
16diff --git a/debian/control b/debian/control
17index 29521f3..ecaae54 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -51,7 +51,8 @@ Build-Depends-Arch: cargo:native,
21 librust-url-2+default-dev (>= 2.5.4-~~),
22 librust-whoami-1-dev (>= 1.5-~~),
23 librust-xmltree-0.10+default-dev
24-Maintainer: Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Rust Maintainers <pkg-rust-maintainers@alioth-lists.debian.net>
27 Uploaders:
28 Jelmer Vernooij <jelmer@debian.org>
29 Standards-Version: 4.7.2
30diff --git a/debian/patches/disable-broken-tests b/debian/patches/disable-broken-tests
31index 2887889..7731f59 100644
32--- a/debian/patches/disable-broken-tests
33+++ b/debian/patches/disable-broken-tests
34@@ -1,8 +1,14 @@
35-Index: ognibuild/src/debian/build_deps.rs
36-===================================================================
37---- ognibuild.orig/src/debian/build_deps.rs
38-+++ ognibuild/src/debian/build_deps.rs
39-@@ -136,6 +136,7 @@ mod tests {
40+--- a/src/debian/build_deps.rs
41++++ b/src/debian/build_deps.rs
42+@@ -126,6 +126,7 @@
43+ use tempfile::TempDir;
44+
45+ #[test]
46++ #[ignore]
47+ fn test_build_dependency_tie_breaker_from_session() {
48+ let _temp_dir = TempDir::new().unwrap();
49+ let session = PlainSession::new();
50+@@ -136,6 +137,7 @@
51 }
52
53 #[test]
54@@ -10,7 +16,7 @@ Index: ognibuild/src/debian/build_deps.rs
55 fn test_build_dependency_tie_breaker_count_empty() {
56 let _temp_dir = TempDir::new().unwrap();
57 let session = PlainSession::new();
58-@@ -147,6 +148,7 @@ mod tests {
59+@@ -147,6 +149,7 @@
60 }
61
62 #[test]
63@@ -18,11 +24,9 @@ Index: ognibuild/src/debian/build_deps.rs
64 fn test_build_dependency_tie_breaker_break_tie_empty() {
65 let _temp_dir = TempDir::new().unwrap();
66 let session = PlainSession::new();
67-Index: ognibuild/src/session/plain.rs
68-===================================================================
69---- ognibuild.orig/src/session/plain.rs
70-+++ ognibuild/src/session/plain.rs
71-@@ -380,6 +380,7 @@ mod tests {
72+--- a/src/session/plain.rs
73++++ b/src/session/plain.rs
74+@@ -380,6 +380,7 @@
75 }
76
77 #[cfg(feature = "breezy")]

Subscribers

People subscribed via source and target branches

to all changes: