Merge lp:~maxb/bzr/no-install-apport into lp:bzr

[Max Bowsher]

Remove installation of apport configuration from setup.py

I propose that we should not try to install Apport configuration files if setup.py is run as root.

If Bazaar is being built as a Debian/Ubuntu package, this code is not relevant, as setup.py is either executed as normal non-root (in which case it does nothing), or under fakeroot (in which case this causes the install to fail, since it tries to write to the real system).

This code would only be triggered in the eventuality of someone doing something like 'sudo python setup.py install', in which case:
 * it's rather unlikely that Apport is even installed
 * there's a distinct possibility the install might be run with --prefix or similar options which change installation directories, in which case it's very bad manners for the package to write to /etc or /usr

[Martin Pool (mbp)]

thanks

review: Approve

[Martin Pool (mbp)]

sent to pqm by email

=== modified file 'setup.py'
--- setup.py	2010-09-30 08:49:08 +0000
+++ setup.py	2010-10-14 21:31:06 +0000
@@ -728,19 +728,6 @@
         # easy_install one
         DATA_FILES = [('man/man1', ['bzr.1'])]
 
-    if sys.platform != 'win32':
-        # see https://wiki.kubuntu.org/Apport/DeveloperHowTo
-        #
-        # checking the paths and hardcoding the check for root is a bit gross,
-        # but I don't see a cleaner way to find out the locations in a way
-        # that's going to align with the hardcoded paths in apport.
-        if os.geteuid() == 0:
-            DATA_FILES += [
-                ('/usr/share/apport/package-hooks',
-                    ['apport/source_bzr.py']),
-                ('/etc/apport/crashdb.conf.d/',
-                    ['apport/bzr-crashdb.conf']),]
-
     # std setup
     ARGS = {'scripts': ['bzr'],
             'data_files': DATA_FILES,