Merge lp:~max-rabkin/ibid/ibid-setup-725330 into lp:~ibid-core/ibid/old-trunk-1.6

Proposed by Max Rabkin
Status: Merged
Approved by: Stefano Rivera
Approved revision: 1016
Merged at revision: 1024
Proposed branch: lp:~max-rabkin/ibid/ibid-setup-725330
Merge into: lp:~ibid-core/ibid/old-trunk-1.6
Diff against target: 11 lines (+1/-0)
1 file modified
scripts/ibid-setup (+1/-0)
To merge this branch: bzr merge lp:~max-rabkin/ibid/ibid-setup-725330
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Stefano Rivera Approve
marcog (community) Abstain
Review via email: mp+51388@code.launchpad.net

Commit message

Set source type for Jabber

To post a comment you must log in.
Revision history for this message
marcog (marco-gallotta) wrote :

Haven't setup a jabber source, so I'll abstain for now.

review: Abstain
Revision history for this message
Max Rabkin (max-rabkin) wrote :

Marco: you can register a Jabber account at jabber.org -- the process is trivial. But, I have tested it. If you do test, make sure you use a source name other than "jabber" (since that would work without this).

Revision history for this message
Stefano Rivera (stefanor) wrote :

It's also worth testing with google talk every now and then. They have a different jabber implementation, which we've run into issues with, before

Revision history for this message
Stefano Rivera (stefanor) :
review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/ibid-setup'
2--- scripts/ibid-setup 2010-09-26 15:38:02 +0000
3+++ scripts/ibid-setup 2011-02-25 23:56:47 +0000
4@@ -104,6 +104,7 @@
5 source['channels'] = [c.strip() for c in channels.split(u',')]
6 source['auth'] = ['hostmask', 'nickserv']
7 elif type_ == u'jabber':
8+ source['type'] = u'jabber'
9 source['jid'] = prompt(u'JID (Jabber address): ')
10 source['password'] = prompt(u'Password: ', secret=True)
11 rooms = prompt(

Subscribers

People subscribed via source and target branches