Merge lp:~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 into lp:ubuntu/trusty/network-manager-applet
Status: | Merged |
---|---|
Merge reported by: | Mathieu Trudel-Lapierre |
Merged at revision: | not available |
Proposed branch: | lp:~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 |
Merge into: | lp:ubuntu/trusty/network-manager-applet |
Diff against target: |
103 lines (+42/-8) 6 files modified
.pc/applied-patches (+1/-0) .pc/git_dont_autostart_under_GNOME.patch/nm-applet.desktop.in (+13/-0) debian/changelog (+8/-0) debian/patches/git_dont_autostart_under_GNOME.patch (+16/-7) debian/patches/series (+1/-0) nm-applet.desktop.in (+3/-1) |
To merge this branch: | bzr merge lp:~matttbe/ubuntu/trusty/network-manager-applet/lp1267100 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | 2014-01-08 | Approve on 2014-03-05 | |
Dmitry Shachnev | Approve on 2014-02-21 | ||
Ubuntu Sponsors Team | 2014-02-21 | Pending | |
Review via email:
|
Description of the change
Hello Mathieu and thank you for maintaining nm-applet packages!
With the latest version (0.9.8.4-1ubuntu1), nm-applet is no longer launched at startup on non Gnome-Shell sessions (e.g. on Cairo-Dock session).
It seems this is because this patch is no longer applied: git_dont_
I'm proposing a new version (please see the branch linked to this bug report) which re-adds this patch.
Note that this patch should no longer be needed with the next 0.9.8.8 version: https:/
- 113. By Mathieu Trudel-Lapierre on 2014-01-24
-
* debian/rules, debian/control: Enable ModemManager1 support.
* debian/patches/ nm-applet- use-indicator. patch: refresh patch for missing
update to the get_icon function for "broadband" devices used by MM1.
Matthieu Baerts (matttbe) wrote : | # |
Dmitry Shachnev (mitya57) wrote : | # |
Hi Matthieu,
Alberts Muktupāvels has notified me about this issue, and I noticed that you already have a MP for that — so thanks for saving my time :)
Hovewer, it is stuck for a month and Mathieu seems to not respond to it. Can you please add ~ubuntu-sponsors to reviewers list so that it shows up in the sponsoring queue?
Dmitry Shachnev (mitya57) wrote : | # |
And, also, we got a new upload two days ago, so please update it before subscribing ubuntu-sponsors.
- 115. By Matthieu Baerts on 2014-02-21
-
* debian/
patches/ git_dont_ autostart_ under_GNOME. patch:
- Re-added this patch to use AutostartCondition: launch nm-applet at
startup on gnome-but-not-shell sessions (LP: #1267100)
Matthieu Baerts (matttbe) wrote : | # |
Hello and thank you for your review.
I just update my branch: this new revision can be "pulled", tagged and pushed ;-)
Mathieu Trudel-Lapierre (cyphermox) wrote : | # |
Approving, but his really should be done against lp:~network-manager/network-manager-applet/ubuntu; I'll apply the changes there manually and upload.
Hello Mathieu,
I just updated this branch to be sync with the trunk (lp:ubuntu/network-manager-applet).
Have a nice day,
Matt