Code review comment for ~matthiasbaur/cloud-init:feature/puppet-csr-attributes

Revision history for this message
Matthias Baur (matthiasbaur) wrote :

Hey Chad,

thanks for taking a look! I'm not quite sure which tests fail in CI as I can't access the URLs. I tried to run it locally on my Mac which lead to a lot of failing tests even for the master branch.

I checked that the following tests succeed for the files I changed:

* make pep8
* make pyflakes
* make pyflakes3
* nosetests tests/unittests/test_handler/test_handler_puppet.py

Regarding the CLA: I couldn't figure out if the company I work for has already signed the CLA. I've reached out to Scott on IRC who told me that he's not working anymore at Canonical. His suggestion was to contact out to powersj, which I tried but couldn't reach.

I'm out of office for two weeks now, will come back to this afterwards.

« Back to merge proposal