Merge lp:~matthew.revell/launchpad/translations-help-10.1 into lp:launchpad
| Status: | Merged | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Henning Eggers on 2010-01-14 | ||||||||||||||||||||||||||||
| Approved revision: | not available | ||||||||||||||||||||||||||||
| Merged at revision: | not available | ||||||||||||||||||||||||||||
| Proposed branch: | lp:~matthew.revell/launchpad/translations-help-10.1 | ||||||||||||||||||||||||||||
| Merge into: | lp:launchpad | ||||||||||||||||||||||||||||
| Diff against target: |
808 lines (+466/-94) 25 files modified
lib/lp/bugs/help/tag-search.html (+5/-5) lib/lp/code/help/register-branch.html (+5/-5) lib/lp/registry/help/home-page-staging-help.html (+5/-5) lib/lp/registry/help/import-pgp-key.html (+5/-5) lib/lp/registry/help/openid.html (+5/-5) lib/lp/registry/help/openpgp-keys.html (+5/-5) lib/lp/registry/help/pgp-key-clearsign.html (+5/-5) lib/lp/registry/help/verify-downloads.html (+5/-5) lib/lp/services/inlinehelp/javascript/inlinehelp.js (+1/-1) lib/lp/soyuz/help/ppa-sources-list.html (+5/-5) lib/lp/translations/help/directory-example.html (+53/-0) lib/lp/translations/help/getting-started-for-your-project.html (+5/-5) lib/lp/translations/help/imported-upload.html (+61/-0) lib/lp/translations/help/importing-from-bzr.html (+37/-0) lib/lp/translations/help/new-to-translating.html (+44/-0) lib/lp/translations/help/reviewing.html (+52/-0) lib/lp/translations/help/successful-imports.html (+46/-0) lib/lp/translations/help/translation-groups.html (+5/-5) lib/lp/translations/help/updated-upload.html (+40/-0) lib/lp/translations/stories/importqueue/xx-translation-import-queue.txt (+1/-1) lib/lp/translations/templates/person-translations.pt (+3/-5) lib/lp/translations/templates/pofile-upload.pt (+3/-3) lib/lp/translations/templates/productseries-translations-settings.pt (+32/-7) lib/lp/translations/templates/productseries-translations-upload.pt (+29/-20) lib/lp/translations/templates/translationimportqueue-index.pt (+9/-2) |
||||||||||||||||||||||||||||
| To merge this branch: | bzr merge lp:~matthew.revell/launchpad/translations-help-10.1 | ||||||||||||||||||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Henning Eggers (community) | code | 2010-01-08 | Approve on 2010-01-12 |
| Eleanor Berger (community) | 2010-01-08 | Approve on 2010-01-11 | |
|
Review via email:
|
|||
| Matthew Revell (matthew.revell) wrote : | # |
| Matthew Revell (matthew.revell) wrote : | # |
| Henning Eggers (henninge) wrote : | # |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Am 08.01.2010 18:36, Matthew Revell schrieb:
>
> This is the first of two branches that fix a number of bugs in the Translations UI text and help, as identified by Matthew R and Danilo at UDS-L.
>
Thanks for doing these. They will certainly help translators and
reviewers in doing a better job.
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,42 @@
> +<html>
> + <head>
> + <title>Example directory layout for translation files</title>
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
OK, these seem to be a problem, as we found out. Please see that you can
fix it and file a bug for the affected existing help pages.
> + </head>
> + <body>
> + <h1>Example directory layout for translation files</h1>
Good, clear explanation.
[...]
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -0,0 +1,59 @@
> +<html>
> + <head>
> + <title>Importing a .po file from upstream</title>
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + <link rel="stylesheet" type="text/css"
> + href="/
> + </head>
> + <body>
> + <h1>Importing a .po file from upstream</h1>
> +
> + <p>
> + Many projects have translation efforts outside of Launchpad. If
> + you help translate that project for Ubuntu, you should import the
> + upstream translations from time to time.
> + </p>
This is also true for any other project that is not hosted on Launchpad
completely and for any other distribution hosted in LP. Can you find a
way to put it that broadens the meaning while still mentioning Ubuntu
(where this is particularly important)?
> +
> + <h2>How Launchpad prioritises imported translation strings</h2>
> +
> + <p>To help ensure the best quality translations end-up in Ubuntu,
just "end up", AFAIK.
Again, not just Ubuntu.
> + Launchpad prioritises translation strings differently depending
> + on where they were made.
> + </p>
> +
> + <p>
> + In general, a translation made in Launchpad will take precedence
[...]
Good explanation of a difficult matter. Well done. ;)
> === added file 'lib/lp/
OK.
> === added file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
| Matthew Revell (matthew.revell) wrote : | # |
Henning, I've addressed your concerns and have also:
* fixed the help pop-up CSS problems
* changed the 'continue' button to be 'Close'
* Addressed 48435 "+imports UI text and help"
I'd be grateful if you'd take another look, please.
| Henning Eggers (henninge) wrote : | # |
Hi Matt,
thanks for the improvements and good job on fixing those other issues!
Just one correction:
+ Following a delay, Launchpad will make an initial import, then check regularly
+ for updates.
This should read something like this:
a new revision to the branch. There is a short delay between a push and the files
The important thing is that the updates are push-driven, not a cron-job. The delay is 15 to 30 minutes, no longer.
After that the branch is good to land!
Henning

This is the first of two branches that fix a number of bugs in the Translations UI text and help, as identified by Matthew R and Danilo at UDS-L.