Merge lp:~matthew.revell/launchpad/ppa-add-repo-help-492283 into lp:launchpad/db-devel
Proposed by
Matthew Revell
on 2010-02-10
| Status: | Merged |
|---|---|
| Approved by: | Gavin Panella on 2010-02-10 |
| Approved revision: | not available |
| Merged at revision: | not available |
| Proposed branch: | lp:~matthew.revell/launchpad/ppa-add-repo-help-492283 |
| Merge into: | lp:launchpad/db-devel |
| Diff against target: |
249 lines (+169/-41) 3 files modified
lib/lp/soyuz/help/ppa-sources-list.html (+164/-37) lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt (+1/-1) lib/lp/soyuz/templates/archive-index.pt (+4/-3) |
| To merge this branch: | bzr merge lp:~matthew.revell/launchpad/ppa-add-repo-help-492283 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gavin Panella (community) | 2010-02-10 | Approve on 2010-02-10 | |
|
Review via email:
|
|||
To post a comment you must log in.
| Matthew Revell (matthew.revell) wrote : | # |
| Gavin Panella (allenap) wrote : | # |
This looks good.
There's a general problem with the help pages, in that they fail validation (no character encoding, no doctype). They work fine, but it would be nice to make them work a little better. Please can you file a bug along the lines of "inline help pages should validate". We can probably make lp.services.
review:
Approve

This branch changes the PPA overview "Read about installing" help pop-up to cover the add-apt-repository method and the terminal method for older versions of Ubuntu.
It also adds a new link to the help pop-up (to the word "adding") that doesn't require that people click to reveal the sources.list snippet.