Launchpad itself

Merge lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297 into lp:launchpad

  1. bug-subscribe-help-bug-484297
  2. Merge into devel
Proposed by Matthew Revell on 2010-02-02
Status: Merged
Approved by: Gavin Panella on 2010-02-02
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297
Merge into: lp:launchpad
Diff against target: 36 lines (+7/-4)
1 file modified
lib/lp/bugs/browser/bug.py (+7/-4)
To merge this branch: bzr merge lp:~matthew.revell/launchpad/bug-subscribe-help-bug-484297
Reviewer Review Type Date Requested Status
Gavin Panella (community) 2010-02-02 Approve on 2010-02-02
Review via email: mp+18458@code.launchpad.net

Commit Message

Adds a tool-tip to the 'subscribe yourself' and 'subscribe someone else' links on bug pages, which notes that subscribing to a bug means Launchpad will send you email. Bug 484297.

To post a comment you must log in.
Matthew Revell (matthew.revell) wrote :

Adds a tool-tip to the 'subscribe yourself' and 'subscribe someone else' links on bug pages, which notes that subscribing to a bug means Launchpad will send you email.

Matthew Revell (matthew.revell) wrote :

Lines 8/9 are where Gedit deleted trailing white space.

Gavin Panella (allenap) wrote :

This is a very nice new feature, beautifully implemented ;)

review: Approve
Gavin Panella (allenap) wrote :

Actually, 28s/bugs/bug.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/bug.py'
2--- lib/lp/bugs/browser/bug.py 2010-01-21 22:07:42 +0000
3+++ lib/lp/bugs/browser/bug.py 2010-02-04 14:40:45 +0000
4@@ -79,7 +79,7 @@
5
6 # Constant for the maximum bug heat we'll use for converting
7 # IBug.heat to ratio. In the future this should come from the DB.
8-# The value must be a float
9+# The value must be a float
10 MAX_HEAT = 5000.0
11
12 class BugNavigation(Navigation):
13@@ -220,12 +220,16 @@
14 else:
15 text = 'Subscribe'
16 icon = 'add'
17- return Link('+subscribe', text, icon=icon)
18+ return Link('+subscribe', text, icon=icon, summary=(
19+ 'When you are subscribed, Launchpad will email you each time '
20+ 'this bug changes'))
21
22 def addsubscriber(self):
23 """Return the 'Subscribe someone else' Link."""
24 text = 'Subscribe someone else'
25- return Link('+addsubscriber', text, icon='add')
26+ return Link(
27+ '+addsubscriber', text, icon='add', summary=(
28+ 'Launchpad will email that person whenever this bugs changes'))
29
30 def nominate(self):
31 """Return the 'Target/Nominate for release' Link."""
32@@ -980,4 +984,3 @@
33 html += '<img src="/@@/flame-bw-icon" />'
34 html += '</span>'
35 return html
36-