Launchpad itself

Merge lp:~matthew.revell/launchpad/also-affects-help-bug-117460 into lp:launchpad

  1. also-affects-help-bug-117460
  2. Merge into devel
Proposed by Matthew Revell on 2010-11-01
Status: Merged
Approved by: Matthew Revell on 2010-11-02
Approved revision: no longer in the source branch.
Merged at revision: 11844
Proposed branch: lp:~matthew.revell/launchpad/also-affects-help-bug-117460
Merge into: lp:launchpad
Diff against target: 103 lines (+69/-1)
3 files modified
lib/lp/bugs/help/also-affects-project-help.html (+58/-0)
lib/lp/bugs/templates/bugtask-choose-affected-product.pt (+8/-0)
lib/lp/bugs/templates/bugtasks-and-nominations-table.pt (+3/-1)
To merge this branch: bzr merge lp:~matthew.revell/launchpad/also-affects-help-bug-117460
Reviewer Review Type Date Requested Status
Henning Eggers (community) code 2010-11-01 Approve on 2010-11-01
Review via email: mp+39751@code.launchpad.net

Commit Message

Adds a help icon link beside the "Also affects project" link on the bug page. Also adds a modified version of Bryce's suggested explanatory text to the +choose-affected-product page.

Description of the Change

This branch adds a help pop-up link beside the "Also affects project" link on the bug page.

I add the link in bugtasks-and-nominations-table.pt and add a also-affects-project-help.html file to the bugs/help directory.

You can test this by visiting https://bugs.launchpad.dev/redfish/+bug/15 and clicking the help icon beside the "Also affects project" link on the bug page.

To post a comment you must log in.
Henning Eggers (henninge) :
review: Approve (code)
Henning Eggers (henninge) wrote :

Very good addition! Thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'lib/lp/bugs/help/also-affects-project-help.html'
2--- lib/lp/bugs/help/also-affects-project-help.html 1970-01-01 00:00:00 +0000
3+++ lib/lp/bugs/help/also-affects-project-help.html 2010-11-01 15:13:54 +0000
4@@ -0,0 +1,58 @@
5+<html>
6+ <head>
7+ <title>Adding another target to a bug report</title>
8+ <link rel="stylesheet" type="text/css"
9+ href="/+icing/yui/cssreset/reset.css" />
10+ <link rel="stylesheet" type="text/css"
11+ href="/+icing/yui/cssfonts/fonts.css" />
12+ <link rel="stylesheet" type="text/css"
13+ href="/+icing/yui/cssbase/base.css" />
14+ </head>
15+ <body>
16+ <h1>Adding another target to a bug report</h1>
17+
18+ <p>
19+ The same bug can crop up in different places.
20+ </p>
21+
22+ <p>
23+ Imagine a bug in a video driver. Not only do the video driver maintainers need to fix the bug in their code but so do the people who package that driver for Ubuntu and other distros.
24+ </p>
25+
26+ <p>
27+ Of course, the version and packaging of that driver may differ between different releases of a particularly distro.
28+ </p>
29+
30+ <p>
31+ And the bug may initially be reported against X.org or some other part of the operating system.
32+ </p>
33+
34+ <p>
35+ Launchpad helps manage this by allowing bug reports to relate to more than one context.
36+ </p>
37+
38+ <p>
39+ So, if you suspect that an existing bug also affects another project or distribution you can add it to the report. That bug report, with the same number and comment history, will then show up just like any other bug report for that project/distro.
40+ </p>
41+
42+ <h2>Where you can report a bug</h2>
43+
44+ <p>
45+ Launchpad can track bugs for:
46+ </p>
47+
48+ <ul>
49+ <li>projects</li>
50+ <li>project series</li>
51+ <li>project groups</li>
52+ <li>distributions</li>
53+ <li>distro series</li>
54+ <li>source pacakges</li>
55+ <li>distro series source packages.</li>
56+ </ul>
57+
58+ <p>
59+ <a href="https://help.launchpad.net/Bugs/MultiProjectBugs" target="_blank">Read more about multi-context bugs &gt;</a>
60+ </p>
61+ </body>
62+</html>
63
64=== modified file 'lib/lp/bugs/templates/bugtask-choose-affected-product.pt'
65--- lib/lp/bugs/templates/bugtask-choose-affected-product.pt 2009-09-08 09:25:58 +0000
66+++ lib/lp/bugs/templates/bugtask-choose-affected-product.pt 2010-11-01 15:13:54 +0000
67@@ -15,6 +15,14 @@
68 <div metal:fill-slot="main">
69
70 <div id="maincontent">
71+
72+ <p>
73+ A bug may need fixing in more than one project. You may add another
74+ project for this bug here.
75+ <a href="/+help/also-affects-project-help.html" target="help"
76+ class="sprite maybe">&nbsp;<span class="invisible-link">(?)</span>
77+ </a>
78+ </p>
79
80 <p tal:content="structure context/fmt:link" />
81
82
83=== modified file 'lib/lp/bugs/templates/bugtasks-and-nominations-table.pt'
84--- lib/lp/bugs/templates/bugtasks-and-nominations-table.pt 2010-06-15 13:51:55 +0000
85+++ lib/lp/bugs/templates/bugtasks-and-nominations-table.pt 2010-11-01 15:13:54 +0000
86@@ -103,7 +103,8 @@
87 <tal:addupstream
88 define="link context_menu/addupstream"
89 condition="link/enabled"
90- replace="structure link/render" />
91+ replace="structure link/render" /><a href="/+help/also-affects-project-help.html" target="help" class="sprite maybe">&nbsp;
92+ <span class="invisible-link">(?)</span></a>
93 <tal:adddistro
94 define="link context_menu/adddistro"
95 condition="link/enabled"
96@@ -113,6 +114,7 @@
97 condition="link/enabled"
98 replace="structure link/render" />
99 </tal:also-affects-links>
100+
101 </div>
102
103 </tal:root>