Merge lp:~matthew.revell/launchpad/10.04-tour-updates into lp:launchpad/db-devel
Proposed by
Matthew Revell
on 2010-04-12
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Brad Crittenden on 2010-04-21 | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp:~matthew.revell/launchpad/10.04-tour-updates | ||||
| Merge into: | lp:launchpad/db-devel | ||||
| Diff against target: |
253 lines (+51/-50) 6 files modified
lib/canonical/launchpad/tour/branch-hosting-tracking (+8/-7) lib/canonical/launchpad/tour/bugs (+9/-7) lib/canonical/launchpad/tour/index (+2/-2) lib/canonical/launchpad/tour/join-launchpad (+2/-2) lib/canonical/launchpad/tour/ppa (+28/-30) lib/canonical/launchpad/tour/translation (+2/-2) |
||||
| To merge this branch: | bzr merge lp:~matthew.revell/launchpad/10.04-tour-updates | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | 2010-04-12 | Approve on 2010-04-20 |
|
Review via email:
|
|||
Description of the Change
This makes text updates to the tour to account for new features.
It also changes the screen shots on the front page so that they have a Lucid theme, rather than Human.
To post a comment you must log in.
| Matthew Revell (matthew.revell) wrote : | # |
Thanks Brad.
I've made each of the changes you requested *apart from* the line wrapping. None of the page templates have ever wrapped at 78 chars as that's how they were delivered by the designer and originally accepted into the LP tree.
As the wrapping issue isn't something I've introduced in this branch, would you mind if I change this another time?
| Brad Crittenden (bac) wrote : | # |
Thanks for making the changes. Your rationale about the state of the line-wrapping makes sense.

Hi Matthew thanks for the change. The new screenshots look good. You're quite ahead of the game by thinking to do that.
One thing I notice about the page templates are you're lack of line wrapping. Our page templates are supposed to wrap at 78 columns unless there is a formatting reason, which I don't see.
Wikipedia capitalizes 'Git' so I think we should too, which I see you fixed in all but one place.
s/community of over 47,000 working/community of over 47,000 people working/