Merge lp:~matthew-t-bentley/duplicity/b2 into lp:~duplicity-team/duplicity/0.7-series

Proposed by Matthew Bentley
Status: Superseded
Proposed branch: lp:~matthew-t-bentley/duplicity/b2
Merge into: lp:~duplicity-team/duplicity/0.7-series
Diff against target: 43 lines (+6/-5)
1 file modified
duplicity/backends/b2backend.py (+6/-5)
To merge this branch: bzr merge lp:~matthew-t-bentley/duplicity/b2
Reviewer Review Type Date Requested Status
duplicity-team Pending
Review via email: mp+279908@code.launchpad.net

This proposal has been superseded by a proposal from 2015-12-08.

Description of the change

Fix import and error typos.

To post a comment you must log in.
lp:~matthew-t-bentley/duplicity/b2 updated
1162. By Matthew Bentley

Merge and re-add missing error

Revision history for this message
edso (ed.so) wrote :

On 08.12.2015 17:04, Matthew Bentley wrote:
> - 'maxFileCount': 1000,
> + 'bucketId': self.bucket_id,
> + 'maxFileCount': 1000,

this looks faulty. we had to revert max file arguments for listings from other cloud backends before, because the listing became incomplete when users had lot's of backups and duplicity couldn't find all files for a chain anymore.

..ede/duply.net

lp:~matthew-t-bentley/duplicity/b2 updated
1163. By Matthew Bentley

Allow multiple backups in the same bucket

1164. By Matthew Bentley

Add debugging for b2backend

1165. By Matthew Bentley

Set fake (otherwise unused) hostname for prettier password prompt
Thanks to Andreas Knab <email address hidden> for the patch

1166. By Matthew Bentley

Make sure listed files are exactly in the requested path
Thanks to Andreas Knab <email address hidden> for the pull request

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'duplicity/backends/b2backend.py'
2--- duplicity/backends/b2backend.py 2015-12-04 11:34:25 +0000
3+++ duplicity/backends/b2backend.py 2015-12-08 16:07:46 +0000
4@@ -27,6 +27,7 @@
5
6 import duplicity.backend
7 from duplicity.errors import BackendException, FatalBackendException
8+from duplicity import log
9
10 import json
11 import urllib2
12@@ -122,8 +123,8 @@
13 endpoint = 'b2_list_file_names'
14 url = self.formatted_url(endpoint)
15 params = {
16- 'bucketId': self.bucket_id,
17- 'maxFileCount': 1000,
18+ 'bucketId': self.bucket_id,
19+ 'maxFileCount': 1000,
20 }
21 try:
22 resp = self.get_or_post(url, params)
23@@ -179,9 +180,9 @@
24 if e.code == 400:
25 return log.ErrorCode.bad_request
26 if e.code == 500:
27- return log.ErrorCode.backed_error
28+ return log.ErrorCode.backend_error
29 if e.code == 403:
30- return log.ErrorCode.backed_permission_denied
31+ return log.ErrorCode.backend_permission_denied
32
33 def find_or_create_bucket(self, bucket_name):
34 """
35@@ -215,7 +216,7 @@
36 'accountId': self.account_id,
37 'bucketName': bucket_name,
38 'bucketType': 'allPrivate'
39- }
40+ }
41 resp = self.get_or_post(url, params)
42
43 self.bucket_id = resp['bucketId']

Subscribers

People subscribed via source and target branches