Code review comment for lp:~matt.hall/endroid/ldap

Revision history for this message
Phil Connell (pconnell) wrote :

This is fine to go in to get things working, but strictly speaking it's a massive hack since it relies on internal details (e.g. _connect method and semantics) of ldaptor.

An ideal outcome would be getting a patch into ldaptor upstream to implement this within ldaptor:

review: Approve

« Back to merge proposal