Merge lp:~matt-goodall/canonical-identity-provider/oops-dictconfig-0.0.6 into lp:canonical-identity-provider/release

Proposed by Matt Goodall
Status: Merged
Approved by: Matt Goodall
Approved revision: no longer in the source branch.
Merged at revision: 1365
Proposed branch: lp:~matt-goodall/canonical-identity-provider/oops-dictconfig-0.0.6
Merge into: lp:canonical-identity-provider/release
Diff against target: 12 lines (+1/-1)
1 file modified
requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~matt-goodall/canonical-identity-provider/oops-dictconfig-0.0.6
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+277872@code.launchpad.net

Commit message

Upgrade to oops-dictconfig v0.0.6.

Description of the change

Upgrade oops-dictconfig to 0.0.6 for compatibility with recently updated oops-datedir-repo.

New datedir-repo uses the new publish API and return ["<oops-id"]. dictconfig 0.0.5 then wraps that in another list resulting in [["<oops-id>"]].

Debugging locally by printing the final result in oops.config.Config.publish shows:

  with dictconfig 0.0.5:

  results in [['OOPS-b3f63e8cbead420199fd55905db4e6eb']]
  writes logs/www-oops/2015-11-18/OOPS-450d967d67246c9b6d05f42edea386d5

  with dictconfig 0.0.6:

  results in ['OOPS-03921b8b38c74cae89553ad9e5082127']
  writes logs/www-oops/2015-11-18/OOPS-c023cfcd3489632a9900685afc5cbf32

Once it reaches staging I can trigger an error and check it looks correct in oops.canonical.com and in the daily report.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'requirements.txt'
2--- requirements.txt 2015-11-10 14:10:56 +0000
3+++ requirements.txt 2015-11-18 16:35:14 +0000
4@@ -19,7 +19,7 @@
5 oops==0.0.13
6 oops-amqp==0.0.7
7 oops-datedir-repo==0.0.22
8-oops-dictconfig==0.0.5
9+oops-dictconfig==0.0.6
10 oops-timeline==0.0.2
11 oops-wsgi==0.0.11
12 paste==2.0.1