Merge lp:~matsubara/ubuntu/trusty/python-urllib3/bug-1412545 into lp:ubuntu/trusty/python-urllib3
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Robie Basak | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~matsubara/ubuntu/trusty/python-urllib3/bug-1412545 | ||||
Merge into: | lp:ubuntu/trusty/python-urllib3 | ||||
Diff against target: |
95 lines (+75/-0) 3 files modified
debian/changelog (+8/-0) debian/patches/05_backport_proxy_fix.patch (+66/-0) debian/patches/series (+1/-0) |
||||
To merge this branch: | bzr merge lp:~matsubara/ubuntu/trusty/python-urllib3/bug-1412545 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robie Basak | 2015-01-26 | Needs Fixing on 2015-01-26 | |
Review via email:
|
Description of the change
This is an attempt to backport the fix for bug LP #1412545.
The issue in the trusty version is that when users are behind a proxy and the
connection is dropped, the library stops using the proxy. The fix has been
committed on 1c30a1f3 python-urllib3 upstream code and released on 1.8.3.
- 13. By Diogo Matsubara on 2015-01-27
-
review comments: fix package versioning, add dep3 headers to patch
Diogo Matsubara (matsubara) wrote : | # |
Hi Robie,
thanks for the review!
> Assuming the patch works, the packaging changes look good.
>
> A few minor corrections:
>
> Please use 1.7.1-1ubuntu0.1 as the version number from an SRU (taken from
> https:/
> which is recommended from
> https:/
Done.
>
> Please can you add dep3 headers to the quilt patch? Described at
> http://
> track where the patch came from and what its current status is. I'm sorry if I
> failed to mention this in our Hangout.
You did mention, I forgot to update it but have done so now.
>
> Finally, please can you check step 3 in
> https:/
> this to process the upload, so we don't upload until all steps before step 5
> are complete. As you backported the patch you're probably the best person to
> assess the potential for regressions and pass this information on the SRU
> team.
Done.
- 14. By Diogo Matsubara on 2015-01-28
-
review comments: fix dep3 headers
Assuming the patch works, the packaging changes look good.
A few minor corrections:
Please use 1.7.1-1ubuntu0.1 as the version number from an SRU (taken from https:/ /wiki.ubuntu. com/SecurityTea m/UpdatePrepara tion#Update_ the_packaging, which is recommended from https:/ /wiki.ubuntu. com/StableRelea seUpdates# Procedure).
Please can you add dep3 headers to the quilt patch? Described at http:// dep.debian. net/deps/ dep3/, these make it easier for other developers to track where the patch came from and what its current status is. I'm sorry if I failed to mention this in our Hangout.
Finally, please can you check step 3 in https:/ /wiki.ubuntu. com/StableRelea seUpdates# Procedure? The SRU team will need this to process the upload, so we don't upload until all steps before step 5 are complete. As you backported the patch you're probably the best person to assess the potential for regressions and pass this information on the SRU team.
Thanks!