Merge lp:~matsubara/maas/packaging into lp:~maas-maintainers/maas/packaging

Proposed by Diogo Matsubara on 2014-05-09
Status: Merged
Approved by: Julian Edwards on 2014-05-12
Approved revision: 275
Merged at revision: 274
Proposed branch: lp:~matsubara/maas/packaging
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~matsubara/maas/packaging
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) 2014-05-09 Approve on 2014-05-10
Review via email: mp+219077@code.launchpad.net

Commit message

python-maas-provisioningserver was missing a dependency on python-crochet.

Description of the change

This branch adds python-crochet as a dependency for the maas-cluster-controller package as an attempt to fix bug 1311765. Currently I get an error installing the maas-cluster charm.

To post a comment you must log in.
Andres Rodriguez (andreserl) wrote :

Hi Diogo,

Thanks for the patch. The dependency is indeed needed, however, python-maas-provisioningserver should depend on it instead of maas-cluster-controller.

Cheers.

review: Needs Fixing
lp:~matsubara/maas/packaging updated on 2014-05-10
275. By Diogo Matsubara on 2014-05-10

move python-crochet dependency to python-maas-provisioningserver

Diogo Matsubara (matsubara) wrote :

> Hi Diogo,
>
> Thanks for the patch. The dependency is indeed needed, however, python-maas-
> provisioningserver should depend on it instead of maas-cluster-controller.
>
> Cheers.

Thanks for the review. Fixed and pushed the change. Is there anything else that needs update?

Andres Rodriguez (andreserl) wrote :

Nope, already released this in Utopic and is part of the SRU for Trusty! THanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-03-25 15:28:23 +0000
3+++ debian/control 2014-05-10 16:25:36 +0000
4@@ -87,6 +87,7 @@
5 Architecture: all
6 Depends: python-amqp,
7 python-celery,
8+ python-crochet,
9 python-distro-info,
10 python-formencode,
11 python-jsonschema,

Subscribers

People subscribed via source and target branches