Merge lp:~matsubara/lp-devops-dashboard/932768-lplib-credential into lp:lp-devops-dashboard
Proposed by
Diogo Matsubara
Status: | Merged |
---|---|
Approved by: | Diogo Matsubara |
Approved revision: | 49 |
Merged at revision: | 49 |
Proposed branch: | lp:~matsubara/lp-devops-dashboard/932768-lplib-credential |
Merge into: | lp:lp-devops-dashboard |
Diff against target: |
72 lines (+10/-7) 3 files modified
src/devops/fetchbugs.py (+6/-6) src/devops/generate.py (+1/-1) src/devops/utils.py (+3/-0) |
To merge this branch: | bzr merge lp:~matsubara/lp-devops-dashboard/932768-lplib-credential |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Launchpad QA | Pending | ||
Review via email:
|
Description of the change
After an update to the download-cache of the devops dashboard, existing launchpadlib credentials weren't used. A new credential file is requested and the existing one ignored. This fix adds the option to use the existing credential file.
Is this the right fix for this issue? Should I get a new credential file using the desktop integration workflow? Is there a way to copy the existing credentials to be used by the desktop workflow?
Thanks!
To post a comment you must log in.
Hi Diogo,
On IRC we talked about using this credential file vs. the keyring. But since this is running on devpad it may be hard to actually authenticate in that environment. So I think the changes you've made here are the best way to go.