Merge lp:~matsubara/charms/trusty/nova-compute-power/trusty into lp:~zulcss/charms/trusty/nova-compute-power/trusty
Proposed by
Diogo Matsubara
Status: | Needs review |
---|---|
Proposed branch: | lp:~matsubara/charms/trusty/nova-compute-power/trusty |
Merge into: | lp:~zulcss/charms/trusty/nova-compute-power/trusty |
Diff against target: |
95 lines (+24/-9) 4 files modified
README (+3/-3) config.yaml (+15/-0) hooks/fabfile.py (+1/-1) hooks/nova_compute_proxy.py (+5/-5) |
To merge this branch: | bzr merge lp:~matsubara/charms/trusty/nova-compute-power/trusty |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chuck Short | Pending | ||
Review via email: mp+237297@code.launchpad.net |
Description of the change
Fixes to nova_compute_
- fix variable name typo: s/self.
- remove trailing command from ssh_key argument as this makes it be interpreted as a tuple
- remove _ from self.key_filename attribute
- remove unnecessary key argument from POWERProxy.
To post a comment you must log in.
Unmerged revisions
- 82. By Diogo Matsubara
-
fix typos in README file
- 81. By Diogo Matsubara
-
fix command to create bridge in the power host
- 80. By Diogo Matsubara
-
add openstack-origin to config.yaml to avoid charmhelpers errors
- 79. By Diogo Matsubara
-
small fixes to charm to avoid install errors: typo in var name, trailing comma, private attribute, unnecessary arg for write_key() method
Added openstack-origin option to config.yaml to avoid charmhelpers errors such as http:// pastebin. ubuntu. com/8508559/ and http:// pastebin. ubuntu. com/8510347/