Code review comment for lp:~matsubara/charms/precise/oops-tools/trunk

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Diogo, this does not look right.

I see config-get's mixed with relation-get's in db-relation-changed/joined.

There is a rabbitmq charm, so I'd like to see a rabbitmq relation in addition to the config.yaml values for the external AMQP server.

Also the check for empty relation values seems to have been removed in db-relation-changed, which may cause race conditions since we may run that hook before the database server has set the values we want.

review: Needs Fixing

« Back to merge proposal