Merge lp:~matiasb/selenium-simple-test/get-firefox-output into lp:selenium-simple-test

[Matias Bordese]

Ported _get_firefox_output method to FirefoxBinary, removed from latest Selenium FirefoxBinary.

See http://stackoverflow.com/questions/27236915/receiving-attribute-error-firefoxbinary-object-has-no-attribute-get-firefox

[Leo Arias (elopio)]

I will report a bug, because we should probably remove the use of _get_firefox_output too.
The change talks about a firefox log, which I think it's new, so we will need to see if that log works for us before updating the _wait_until_connectable. For now, this is the simplest solution, so thanks a lot.

review: Approve

=== modified file 'src/sst/browsers.py'
--- src/sst/browsers.py	2013-08-14 13:26:05 +0000
+++ src/sst/browsers.py	2015-04-14 22:26:15 +0000
@@ -138,6 +138,11 @@
             command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
             env=self._firefox_env)
 
+    def _get_firefox_output(self):
+        # since Selenium 2.44, there is no more _get_firefox_output() method
+        # available in a FirefoxBinary class
+        return self.process.communicate()[0]
+
     def _wait_until_connectable(self):
         """Blocks until the extension is connectable in the firefox.