Merge lp:~matiasb/selenium-simple-test/get-firefox-output into lp:selenium-simple-test

Proposed by Matias Bordese on 2015-04-14
Status: Merged
Approved by: Leo Arias on 2015-04-15
Approved revision: 440
Merged at revision: 440
Proposed branch: lp:~matiasb/selenium-simple-test/get-firefox-output
Merge into: lp:selenium-simple-test
Diff against target: 14 lines (+5/-0)
1 file modified
src/sst/browsers.py (+5/-0)
To merge this branch: bzr merge lp:~matiasb/selenium-simple-test/get-firefox-output
Reviewer Review Type Date Requested Status
Leo Arias (community) 2015-04-14 Approve on 2015-04-15
Review via email: mp+256244@code.launchpad.net

Commit message

Ported _get_firefox_output method to FirefoxBinary, removed from latest Selenium FirefoxBinary.

To post a comment you must log in.
Leo Arias (elopio) wrote :

I will report a bug, because we should probably remove the use of _get_firefox_output too.
The change talks about a firefox log, which I think it's new, so we will need to see if that log works for us before updating the _wait_until_connectable. For now, this is the simplest solution, so thanks a lot.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/sst/browsers.py'
2--- src/sst/browsers.py 2013-08-14 13:26:05 +0000
3+++ src/sst/browsers.py 2015-04-14 22:26:15 +0000
4@@ -138,6 +138,11 @@
5 command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
6 env=self._firefox_env)
7
8+ def _get_firefox_output(self):
9+ # since Selenium 2.44, there is no more _get_firefox_output() method
10+ # available in a FirefoxBinary class
11+ return self.process.communicate()[0]
12+
13 def _wait_until_connectable(self):
14 """Blocks until the extension is connectable in the firefox.
15

Subscribers

People subscribed via source and target branches