Merge lp:~matiasb/canonical-identity-provider/add-openid-rp-config-command into lp:canonical-identity-provider/release

[Matias Bordese]

Added helper management command to create openID RP configs.

Added helper management command to create openID RP configs.

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== added file 'identityprovider/management/commands/add_openid_rp_config.py'
--- identityprovider/management/commands/add_openid_rp_config.py	1970-01-01 00:00:00 +0000
+++ identityprovider/management/commands/add_openid_rp_config.py	2013-03-13 16:10:27 +0000
@@ -0,0 +1,25 @@
+from optparse import make_option
+
+from django.core.management.base import BaseCommand, CommandError
+
+from identityprovider.models import OpenIDRPConfig
+
+
+class Command(BaseCommand):
+    args = '<trust_root>'
+    option_list = BaseCommand.option_list + (
+        make_option('--allow-unverified', action="store_true",
+                    default=False, dest='allow_unverified'),
+        make_option('--allowed-sreg', action="store", dest='allowed_sreg'))
+    help = "Create OpenID RP config entry."
+
+    def handle(self, *args, **kwargs):
+        if len(args) < 1:
+            raise CommandError("Need to specify trust_root")
+
+        trust_root = args[0]
+        allow_unverified = kwargs.get('allow_unverified', False)
+        allowed_sreg = kwargs.get('allowed_sreg', '')
+        OpenIDRPConfig.objects.create(
+            trust_root=trust_root, allow_unverified=allow_unverified,
+            allowed_sreg=allowed_sreg)

=== added file 'identityprovider/tests/test_command_add_openid_rp_config.py'
--- identityprovider/tests/test_command_add_openid_rp_config.py	1970-01-01 00:00:00 +0000
+++ identityprovider/tests/test_command_add_openid_rp_config.py	2013-03-13 16:10:27 +0000
@@ -0,0 +1,45 @@
+from StringIO import StringIO
+
+from django.core.management import call_command
+from django.test import TestCase
+
+from mock import patch
+
+from identityprovider.models import OpenIDRPConfig
+from identityprovider.utils import get_object_or_none
+
+
+class AddOpenIDRPConfigCommandTestCase(TestCase):
+
+    @patch('sys.exit')
+    def test_add_without_root(self, mock_sys_exit):
+        stderr = StringIO()
+        call_command('add_openid_rp_config', stderr=stderr)
+        mock_sys_exit.assert_called_once_with(1)
+        stderr.seek(0)
+        output = stderr.read()
+        self.assertIn('Error: Need to specify trust_root', output)
+
+    def test_add_default(self):
+        root = 'http://localhost:8000'
+        call_command('add_openid_rp_config', root)
+        config = get_object_or_none(OpenIDRPConfig, trust_root=root)
+        self.assertTrue(config)
+        self.assertFalse(config.allow_unverified)
+        self.assertEqual(config.allowed_sreg, '')
+
+    def test_add_with_allow_unverified(self):
+        root = 'http://localhost:8000'
+        call_command('add_openid_rp_config', root, allow_unverified=True)
+        config = get_object_or_none(OpenIDRPConfig, trust_root=root)
+        self.assertTrue(config)
+        self.assertTrue(config.allow_unverified)
+
+    def test_add_with_sreg_value(self):
+        root = 'http://localhost:8000'
+        call_command(
+            'add_openid_rp_config', root, allowed_sreg='nickname,email')
+        config = get_object_or_none(OpenIDRPConfig, trust_root=root)
+        self.assertTrue(config)
+        self.assertFalse(config.allow_unverified)
+        self.assertEqual(config.allowed_sreg, 'nickname,email')