Scratch

Merge lp:~mathias-porten/scratch/fix-1467148 into lp:~elementary-apps/scratch/scratch

  1. fix-1467148
  2. Merge into scratch
Proposed by mporten
Status: Superseded
Proposed branch: lp:~mathias-porten/scratch/fix-1467148
Merge into: lp:~elementary-apps/scratch/scratch
Diff against target: 12 lines (+1/-1)
1 file modified
src/Dialogs/PreferencesDialog.vala (+1/-1)
To merge this branch: bzr merge lp:~mathias-porten/scratch/fix-1467148
Reviewer Review Type Date Requested Status
xapantu (community) Needs Fixing
Danielle Foré Pending
Review via email: mp+268245@code.launchpad.net

Description of the change

Changed sections of settings dialog from bold to <h4>

To post a comment you must log in.
Revision history for this message
xapantu (xapantu) wrote :

I get this error when I launch scratch with your code:

[_LOG_LEVEL_WARN 18:29:57.707047] [Gtk] Failed to set text from markup due to error parsing markup: Unknown tag 'h4' on line 1 char 21

Here is what is done for instance in Pantheon Files:
label.get_style_context ().add_class ("h4");

Please test your merge request at least once before asking for a review ;)

review: Needs Fixing
lp:~mathias-porten/scratch/fix-1467148 updated
1543. By mporten

Changed sections in settings dialog to h4

1544. By mporten

merged from trunk

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs/PreferencesDialog.vala'
2--- src/Dialogs/PreferencesDialog.vala 2015-07-06 17:30:24 +0000
3+++ src/Dialogs/PreferencesDialog.vala 2015-08-17 15:23:05 +0000
4@@ -103,7 +103,7 @@
5
6 void add_section (Gtk.Grid grid, Gtk.Label name, ref int row) {
7 name.use_markup = true;
8- name.set_markup ("<b>%s</b>".printf (name.get_text ()));
9+ name.set_markup ("<h4>%s</h4>".printf (name.get_text ()));
10 name.halign = Gtk.Align.START;
11 grid.attach (name, 0, row, 1, 1);
12 row ++;

Subscribers

People subscribed via source and target branches