Merge ~mateus-morais/ubuntu/+source/ivar:fix-ivar-ftbfs into ubuntu/+source/ivar:ubuntu/devel

Proposed by Mateus Rodrigues de Morais
Status: Merged
Merged at revision: 44a47cc79e8793d582f83a125c3b4a02656724bb
Proposed branch: ~mateus-morais/ubuntu/+source/ivar:fix-ivar-ftbfs
Merge into: ubuntu/+source/ivar:ubuntu/devel
Diff against target: 40 lines (+10/-2)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/rules (+1/-1)
Reviewer Review Type Date Requested Status
Graham Inggs (community) Approve
Review via email: mp+452663@code.launchpad.net

Description of the change

This aims to fix ivar FTBFS on amd64 and arm64 by disabling LTO.

PPA test build: https://launchpad.net/~mateus-morais/+archive/ubuntu/ivar-ftbfs

To post a comment you must log in.
Revision history for this message
Dan Bungert (dbungert) wrote :

Hi Mateus,

The change itself looks fine but the tests are failing in the PPA build. Let's look into that before we go further.

Revision history for this message
Graham Inggs (ginggs) wrote :

Dan, unless I missed something, the buid-time tests passed on amd64 and arm64.
ivar has never built on armhf, ppc64el and s390x before, so let's not block on that.

I also triggered the autopkgtests in the PPA and they succeeded on amd64 and arm64:
https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-mateus-morais-ivar-ftbfs/?format=plain

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index c42afdf..ae56127 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+ivar (1.4.2+dfsg-2ubuntu1) mantic; urgency=medium
7+
8+ * d/rules: disable LTO to fix failure to build from source on amd64 and
9+ arm64 on Ubuntu. (LP: #2037769)
10+
11+ -- Mateus Rodrigues de Morais <mateus.morais@canonical.com> Wed, 27 Sep 2023 12:41:50 -0300
12+
13 ivar (1.4.2+dfsg-2) unstable; urgency=medium
14
15 [ Adrian Bunk ]
16diff --git a/debian/control b/debian/control
17index e988ddf..6611738 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,5 +1,6 @@
21 Source: ivar
22-Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Debian Med Packaging Team <debian-med-packaging@lists.alioth.debian.org>
25 Uploaders: Andreas Tille <tille@debian.org>,
26 Étienne Mollier <emollier@debian.org>
27 Section: science
28diff --git a/debian/rules b/debian/rules
29index ac8d3f4..2ed3239 100755
30--- a/debian/rules
31+++ b/debian/rules
32@@ -1,7 +1,7 @@
33 #!/usr/bin/make -f
34 # DH_VERBOSE := 1
35 export LC_ALL=C.UTF-8
36-export DEB_BUILD_MAINT_OPTIONS=hardening=+all
37+export DEB_BUILD_MAINT_OPTIONS=hardening=+all optimize=-lto
38
39 # Fix a shift against reference data on i386 causing autopkgtest regressions.
40 ifneq (,$(filter $(DEB_HOST_ARCH),i386))

Subscribers

People subscribed via source and target branches