Merge lp:~mateo-salta/developer-ubuntu-com/fix-myapps-phone into lp:developer-ubuntu-com

[Mateo Salta]

This change is primarily a quick two min link change (in text editing..) that addresses the ability to access the "myapps section" on smaller scale screens and devices.

Only "templates/website_base.html" was changed, and only the primary level navigation for login/logout which previously was linked to nothing with "#"

The new link for this is now "https://myapps.developer.ubuntu.com/openid/login/?next=/dev/click-apps/" and will allow users to to login, and since the user name is displayed after login, it will still make sense to take them to their account on clicking their name. This preserves expected behavior on the larger size, and fixes no action happening on smaller sizes.

This fixes this bug: https://bugs.launchpad.net/developer-ubuntu-com/+bug/1409492
https://plus.google.com/+SzymonWaliczek/posts/d18QLYtXgGq

[Michael Hall (mhall119)]

A couple of concerns:

1) This links to the same place from two different entries with two different texts in the same menu.

2) The "Log Out" menu entry logs you out of the CMS, but the "Log In" entry logs you into MyApps, it's confusing to have these operate against different systems.

It may be better to remove MyApps from the sub-menu completely and make only the top-level link there instead.

review: Needs Fixing

[Michael Hall (mhall119)]

Unfortunately both this solution and my recommendation leave the problem of the "Log In" link not changing after you click on it and log in, because you're logging in to a different system. This is likely to lead to confusion as well.

[Mateo Salta (mateo-salta)]

currently the link dosent change, only the display to your user name, they both link to nothing "#" at the top level, and none of the sub level is exposed.

Currently the only sublevel I see under login is myapps? Would you be willing to redirect that on the login button only as a compromise,

Is the intended function of login supposed to take you to u1 to do a general login? It seems it dosnt currently do that.

[Michael Hall (mhall119)]

We had planned to have the top-level login log you into developer.ubuntu.com itself once we added functionality that would require it (like leaving comments, adding snippets, etc), but to be honest we've taken so long to add those I don't feel it's valid to block your changes because of those plans.

My bigger concern is making "Log in" take you to a login screen that actually belongs to a different system (MyApps), and the confusion that will cause. Currently since "Log in" doesn't do anything, you don't get that confusion. If we're going to change that, we should consider changing the text to something other than "Log in".

[Mateo Salta (mateo-salta)]

Ah, intresting - in that case we could comment out the sub navigation, and make it directly say "MyApps" untill there is a login system directly for developer.Ubuntu.com (andlet it stay the same on the logout/username, for the cms developer side), as there is no indrect way of getting to the myapps section outside of this link, and currently clicking login is a non-action I don't think that is good to present the user on larger screens either, Ill push a change that attempts that.

[lp:~mateo-salta/developer-ubuntu-com/fix-myapps-phone]

210. By Mateo Salta on 2016-04-10

Revise to only change log in link and display text

[Mateo Salta (mateo-salta)]

so, this change put the "logout" link back the way it was, preserving the cms side of things as is.

But changing the "login" section to a primary navigation only to "My Apps" in name and link. (since normal users are not logged into the cms they can use my apps as expected, and since the "Log in" actually dosn't function to log any one in right now, we can remove that altogether.)

[Michael Hall (mhall119)]

Since this is a change in the text of the top-level navigation, I'd like to get more commentary on is before accepting the change.

I personally would lean more towards something like "Store" rather than "My Apps", but let's see what others suggest.

review: Needs Information

[Mateo Salta (mateo-salta)]

True, it is called "Ubuntu Store" on the phone - although the page logo says "ubuntu myapps" lower case one word, store might be a better catch-all with the different click/snappy/software center things on the page.

So is it "myapps", "MyApps" "My Apps", ect. if they do go that route? (before the secondary nav said "My Apps")

[David Callé (davidc3)]

Thanks for the proposal Mateo!

At first glance, I would go with Store, but we actually had a discussion a week ago, about renaming "Publish" to "Store". The main drawback we found is that non-developers or new developers would assume that there is a web frontend to the store.

"My Apps" works for me. It's consistent with what we already have, it's exactly what's behind the link, it won't clash with any name change for "Publish".

+1

[Daniel Holbach (dholbach)]

+1 to what David Callé said.

[Michael Hall (mhall119)]

"My Apps" works for me as well, Mateo can you make that change?

[Stephen Stewart (stephen-stewart)]

Hi,

Thanks for doing this!

We're going to change the name in the banner of https://myapps.developer.ubuntu.com from "Ubuntu myapps" to "Ubuntu store" soon (for 16.04), and update urls in due course, because nobody calls it MyApps :)

Also, we're going to add some copy to explain more about the store (store as in warehouse, not store as in shop) to the landing page, so I would link directly to https://myapps.developer.ubuntu.com rather a login redirect.

Lower case 'store' in the banner is to meet the style guide on logo + text (right?) but I'd expect the nav and elsewhere to be "Store".

review: Needs Fixing

[Mateo Salta (mateo-salta)]

Awesome, so "My Apps" until they do the branding, banner, front end, and landing page copy. Then "Store" with that change.

Then changing the link to https://myapps.developer.ubuntu.com/ to hit the landing page first.

Unless we are talking days away, then we can push it to "Store" to match.

[lp:~mateo-salta/developer-ubuntu-com/fix-myapps-phone]

211. By Mateo Salta on 2016-04-11

Change link to landing page, keep 'My Apps' untill changes

[Stephen Stewart (stephen-stewart)]

wfm

review: Approve

[David Planella (dpm)]

+1. Ideally, we'd make the change in a way that the name can be changed in the CMS, but as it's template-based, I'm not sure it's possible.

review: Approve

=== modified file 'templates/website_base.html'
--- templates/website_base.html	2015-10-29 15:49:15 +0000
+++ templates/website_base.html	2016-04-11 15:58:24 +0000
@@ -78,7 +78,7 @@
 		    <a href="#">{{ user.first_name|default:user.email }}</a>
 		    <ul class="second-level-nav">
 			<li>
-			    <a href="https://myapps.developer.ubuntu.com/openid/login/?next=/dev/click-apps/">My Apps</a>
+			    <a href="https://myapps.developer.ubuntu.com/">My Apps</a>
 			</li>
 			<li>
 			    <a href="/logout?next={{request.path}}"">{% trans "Log out" %}</a>
@@ -87,12 +87,7 @@
 		</li>
 		{% else %}
 		<li class="login">
-		    <a href="#">{% trans "Log in" %}</a>
-		    <ul class="second-level-nav">
-			<li>
-			    <a href="https://myapps.developer.ubuntu.com/openid/login/?next=/dev/click-apps/">My Apps</a>
-			</li>
-		    </ul>
+		    <a href="https://myapps.developer.ubuntu.com/">{% trans "My Apps" %}</a>
 		</li>		
 		{% endif %}
                 </ul>