Merge lp:~marvil07/do-plugins/GNOME-Calculator into lp:do-plugins

[marvil07]

[marvil07 (marvil07)]

use "=" as the identifier for expressions to process inside gnome-calculator

[Chris S. (cszikszoy)]

Why limit the possible items for the GNOME Calculator action to just those that have an "=" at the beginning?

review: Needs Information

[marvil07 (marvil07)]

Hi Chris,

Thanks for the review!

Originally, when I write GNOME-Calculator Alex suggest me to make a regex filter for it.

This patch is a simple solution to avoid having a regex(I tried it, but it's hard[1] I think) to filter the input.

Also, IIRC this is also a solution in other software that do the same, so why not follow a good desition :-)

[1] http://git.gnome.org/cgit/gcalctool/tree/src/mp-equation-parser.y

review: Needs Information (answering)

[marvil07 (marvil07)]

I did not say any reason :(

The main reason is for avoid having this plugin suggested if we do not want to use it(we decide it by not prefixing the expression with "=")

Unmerged revisions

674. By marvil07 on 2009-11-17

filter expression for gnome-calculator plugin using "=" at the start

=== modified file 'GNOME-Calculator/src/GCalcToolAction.cs'
--- GNOME-Calculator/src/GCalcToolAction.cs	2009-11-10 03:14:57 +0000
+++ GNOME-Calculator/src/GCalcToolAction.cs	2009-11-17 20:40:24 +0000
@@ -54,13 +54,22 @@
             get { yield return typeof (ITextItem); }
         }
 
+        public override bool SupportsItem (Item item)
+        {
+            if (item is ITextItem) {
+                string text = item.ToString();
+                return text.StartsWith("=");
+            }
+            return false;
+        }
+
         public override IEnumerable<Item> Perform (IEnumerable<Item> items, IEnumerable<Item> modItems)
         {
             string expression = (items.First () as ITextItem).Text;
             string result = "";
             string error = AddinManager.CurrentLocalizer.GetString ("Sorry I couldn't understand your expression, try another way");
 	    
-            ProcessStartInfo ps = new ProcessStartInfo ("gcalctool", "-s \"" + expression + "\"");
+            ProcessStartInfo ps = new ProcessStartInfo ("gcalctool", "-s \"" + expression.Substring(1) + "\"");
             ps.UseShellExecute = false;
             ps.RedirectStandardOutput = true;
             Process p = Process.Start (ps);