Merge lp:~martinarrieta/mysql-fabric/BUG-71445 into lp:mysql-fabric
Status: | Needs review |
---|---|
Proposed branch: | lp:~martinarrieta/mysql-fabric/BUG-71445 |
Merge into: | lp:mysql-fabric |
Diff against target: |
103 lines (+45/-4) 2 files modified
lib/mysql/fabric/command.py (+4/-2) lib/mysql/fabric/services/health.py (+41/-2) |
To merge this branch: | bzr merge lp:~martinarrieta/mysql-fabric/BUG-71445 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Oracle/MySQL Engineering | Pending | ||
Review via email: mp+218223@code.launchpad.net |
Description of the change
Hello,
I have added the Json support for the returned string and I also have added a dispatcher method for the Group Health as an example about why this Json string is useful.
For example:
# mysqlfabric group health test1
Group health:
serverid = 12f4a168-
is_alive = False
status = FAULTY
address = 192.168.70.102
threads = {}
serverid = 1189e6be-
is_alive = False
status = FAULTY
address = 192.168.70.103
threads = {}
serverid = 0efa44fb-
is_alive = False
status = FAULTY
address = 192.168.70.104
threads = {}
We can try to re-wrinte the default dispatcher to iterate the result in order to make a "general" solution, but this will depend if you like the idea or not.
Please let me know what do you think and if you want to change anything feel free to do it or let me know it and I'll do it.
Regards,
Martin Arrieta.
@martinarrietac
Unmerged revisions
- 228. By Martin Arrieta
-
Fixed error with groups that does not exist
- 227. By Martin Arrieta
-
Changed the method from dispatcher to command_status
- 226. By Martin Arrieta
-
fixex the group health command
- 225. By Martin Arrieta
-
Adding Json support for the result
- 224. By Martin Arrieta
-
added the address of the servers to the group health command