~martin-kalcok/juju-verify:target-machine

Branch merges

Propose for merging

Merged into ~canonical-solutions-engineering/juju-verify:master at revision 12f01da7d8512b654b725c489c131757db214d3f

Alvaro Uria (community): Approve on 2021-02-17

Canonical Solutions Engineering Team: Pending requested 2021-02-16

Canonical Solutions Engineering Team: Pending requested 2021-02-16

Diff: 168 lines (+105/-4)

2 files modified

juju_verify/juju_verify.py (+26/-2)
tests/unit/test_juju_verify.py (+79/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

7a42c7f... by Martin Kalcok on 2021-02-17

simplify for loop to list comprehension

24d1cc5... by Martin Kalcok on 2021-02-16

Allow targeting juju-verify on machines with -M/--machine option

76f2697... by Martin Kalcok on 2021-02-16

Log warning if other principal units are on the affected machine

Reviewed-on: https://code.launchpad.net/~martin-kalcok/juju-verify/+git/juju-verify/+merge/398004
Reviewed-by: Alvaro Uria <email address hidden>
Reviewed-by: Robert Gildein <email address hidden>

5b2f2c4... by Martin Kalcok on 2021-02-16

Added inline comment with brief explanation of of `len(models) > 1` check

1075fca... by Martin Kalcok on 2021-02-15

replaced for loop with set comprehension

53e340b... by Martin Kalcok on 2021-02-15

If we mock juju.loop we need to replace our async functions with non-async MagicMock.

3b2f170... by Martin Kalcok on 2021-02-12

Remove task from todo list

6e35dee... by Martin Kalcok on 2021-02-12

Log warning if other principal units are on the affected machine

924ab07... by Alvaro Uria on 2021-02-15

PY36 support on unit tests

Reviewed-on: https://code.launchpad.net/~aluria/juju-verify/+git/juju-verify/+merge/398051
Reviewed-by: Martin Kalcok <email address hidden>

d0e08be... by Alvaro Uria on 2021-02-15

Update setup.cfg with min Python version