Merge lp:~martin-hilton/charms/xenial/redis/update-relation-settings into lp:~juju-gui/charms/xenial/redis/trunk

Proposed by Martin Hilton
Status: Merged
Merged at revision: 11
Proposed branch: lp:~martin-hilton/charms/xenial/redis/update-relation-settings
Merge into: lp:~juju-gui/charms/xenial/redis/trunk
Diff against target: 12 lines (+2/-0)
1 file modified
hooks/relations.py (+2/-0)
To merge this branch: bzr merge lp:~martin-hilton/charms/xenial/redis/update-relation-settings
Reviewer Review Type Date Requested Status
Francesco Banconi Approve
Review via email: mp+323898@code.launchpad.net

Description of the change

Add an additional relation parameter to make charm compatible with the redis interface (http://interfaces.juju.solutions/interface/redis/).

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/relations.py'
2--- hooks/relations.py 2015-05-25 10:42:20 +0000
3+++ hooks/relations.py 2017-05-11 10:39:16 +0000
4@@ -23,6 +23,8 @@
5 config = hookenv.config()
6 return {
7 'hostname': hookenv.unit_private_ip(),
8+ # The interface layer for redis calls this "host" so send both.
9+ 'host': hookenv.unit_private_ip(),
10 'port': config['port'],
11 'password': config['password'].strip(),
12 }

Subscribers

People subscribed via source and target branches