Merge lp:~martin-hilton/charm-haproxy/000-check_haproxy-https-services into lp:charm-haproxy

[Martin Hilton]

Update NRPE check to support Xenial.

Parse CSV from haproxy's HTTP stats interface

This adds support for HTTPS services in the check_haproxy script. The script is courtesy of Canonical IS.

[Free Ekanayaka (free.ekanayaka)]

A couple of remarks below.

review: Needs Information

[lp:~martin-hilton/charm-haproxy/000-check_haproxy-https-services]

107. By Martin Hilton on 2016-10-24

check_haproxy: Get the "stats socket" from the configuration

[Adam Collard (adam-collard)]

This will only work if global_stats_socket config option is turned on, which is not true for all deployments.

I think we can keep the CSV parsing but grab it over HTTP.

e.g.

$ curl 'http://localhost:10000/;csv' -u haproxy:haproxy

review: Needs Fixing

[lp:~martin-hilton/charm-haproxy/000-check_haproxy-https-services]

108. By Martin Hilton on 2016-10-25

return to using http, but get csv in stead of html

[lp:~martin-hilton/charm-haproxy/000-check_haproxy-https-services]

109. By Martin Hilton on 2016-10-25

more review updates

[Adam Collard (adam-collard)]

Looks good, +1

Thanks for the re-work, think it's good to land.

review: Approve

[Marco Ceppi (marcoceppi)]

LGTM +1

review: Approve

=== modified file 'files/nrpe/check_haproxy.sh'
--- files/nrpe/check_haproxy.sh	2016-07-07 16:50:53 +0000
+++ files/nrpe/check_haproxy.sh	2016-10-25 11:31:20 +0000
@@ -3,34 +3,29 @@
 # This file is managed by Juju
 #--------------------------------------------
 #
-# Copyright 2009,2012 Canonical Ltd.
-# Author: Tom Haddon
-
-CRITICAL=0
-NOTACTIVE=''
-LOGFILE=/var/log/nagios/check_haproxy.log
+# Copyright 2009,2012,2016 Canonical Ltd.
+# Author: Tom Haddon, Junien Fridrick, Martin Hilton
+
+set -e
+set -o pipefail
+
+export LOGFILE=/var/log/nagios/check_haproxy.log
 AUTH=$(grep -r "stats auth" /etc/haproxy | head -1 | awk '{print $4}')
 
-HAPROXY_VERSION="$(dpkg-query -W --showformat='${Version}\n' haproxy)"
-if dpkg --compare-versions "$HAPROXY_VERSION" ge 1.5; then
-    CLASS_REGEX='(active_up|backup_up)'
-else
-    CLASS_REGEX='(active|backup)(2|3)'
-fi
-
-for appserver in $(grep '    server' /etc/haproxy/haproxy.cfg | awk '{print $2'});
-do
-    output=$(/usr/lib/nagios/plugins/check_http -a ${AUTH} -I 127.0.0.1 -p 10000 --regex="class=\"$CLASS_REGEX.*${appserver}" -e ' 200 OK')
-    if [ $? != 0 ]; then
-        date >> $LOGFILE
-        echo $output >> $LOGFILE
-        /usr/lib/nagios/plugins/check_http -a ${AUTH} -I 127.0.0.1 -p 10000 -v | grep $appserver >> $LOGFILE 2>&1
-        CRITICAL=1
-        NOTACTIVE="${NOTACTIVE} $appserver"
-    fi
-done
-
-if [ $CRITICAL = 1 ]; then
+NOTACTIVE=$(curl -s -f -u ${AUTH} "http://localhost:10000/;csv"|awk -F, -v SVNAME=2 -v STATUS=18 '
+	$1 ~ "^#" { next }
+	$SVNAME ~ "(FRONT|BACK)END" { next }
+	$STATUS != "UP" {
+		"date"| getline date
+		print date >> ENVIRON["LOGFILE"]
+		printf("Server %s is in status %s\n", $SVNAME, $STATUS) >> ENVIRON["LOGFILE"]
+		print $0 >> ENVIRON["LOGFILE"]
+		na[na_count++] = $SVNAME
+	}
+	END { ORS=" "; for (i=0; i < na_count; i++) { print na[i] }}
+')
+
+if [ -n "$NOTACTIVE" ]; then
     echo "CRITICAL:${NOTACTIVE}"
     exit 2
 fi