Merge lp:~martin-borho/ubuntu-weather-app/iconfix into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Martin Borho on 2013-05-18
Status: Merged
Approved by: Raúl Yeguas on 2013-05-18
Approved revision: 21
Merged at revision: 21
Proposed branch: lp:~martin-borho/ubuntu-weather-app/iconfix
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 17 lines (+6/-1)
1 file modified
components/WeatherConditionIconComponent.qml (+6/-1)
To merge this branch: bzr merge lp:~martin-borho/ubuntu-weather-app/iconfix
Reviewer Review Type Date Requested Status
Raúl Yeguas 2013-05-18 Approve on 2013-05-18
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2013-05-18
Review via email: mp+164586@code.launchpad.net

Commit message

hotfix for inaccurate api data (icon code incorrect)

Description of the change

Fix for broken value in OWM api response for condition icon. See http://bugs.openweathermap.org/issues/72

To post a comment you must log in.
review: Approve (continuous-integration)
Raúl Yeguas (neokore) wrote :

Thank you for being noticing these kind of details. Great work!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/WeatherConditionIconComponent.qml'
2--- components/WeatherConditionIconComponent.qml 2013-04-21 18:05:01 +0000
3+++ components/WeatherConditionIconComponent.qml 2013-05-18 11:01:26 +0000
4@@ -18,7 +18,12 @@
5 property bool __snow: false
6 property bool __fog: false
7
8- onConditionChanged: weatherCondition.state = condition
9+ onConditionChanged: {
10+ // hotfix for inaccurate api data
11+ // see http://bugs.openweathermap.org/issues/72
12+ if(condition === "10") condition ="10d"
13+ weatherCondition.state = condition
14+ }
15
16 Image {
17 id: sun

Subscribers

People subscribed via source and target branches