Merge lp:~martin-borho/ubuntu-weather-app/ScrollingBottomMarginAndGradientColorScheme into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Martin Borho
Status: Merged
Approved by: David Planella
Approved revision: 117
Merged at revision: 116
Proposed branch: lp:~martin-borho/ubuntu-weather-app/ScrollingBottomMarginAndGradientColorScheme
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 24 lines (+3/-0)
2 files modified
components/CurrentWeather.qml (+1/-0)
components/GradientsMap.js (+2/-0)
To merge this branch: bzr merge lp:~martin-borho/ubuntu-weather-app/ScrollingBottomMarginAndGradientColorScheme
Reviewer Review Type Date Requested Status
David Planella Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+186127@code.launchpad.net

Commit message

Added bottom margin to scrolling area in tabs and moved warm colors up the gradient color scheme

Description of the change

* added bottom margin to scrolling area in tabs (less interference with the toolbar)
* moved warm colors up the gradient color scheme

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'components/CurrentWeather.qml'
2--- components/CurrentWeather.qml 2013-09-14 11:46:25 +0000
3+++ components/CurrentWeather.qml 2013-09-17 18:20:00 +0000
4@@ -45,6 +45,7 @@
5 height: parent.height-units.gu(9.5)
6 width:parent.width
7 anchors.bottom: parent.bottom
8+ anchors.bottomMargin: units.gu(2)
9 onClicked: {
10 mouse.accepted = true;
11 if(!wasHourlyScrolled) {
12
13=== modified file 'components/GradientsMap.js'
14--- components/GradientsMap.js 2013-08-28 13:55:53 +0000
15+++ components/GradientsMap.js 2013-09-17 18:20:00 +0000
16@@ -46,6 +46,8 @@
17 }
18
19 var getGradients = function(celsius) {
20+ // move warm colors up
21+ celsius -= 8
22 // stay in range
23 if(celsius < -30) celsius = -30;
24 else if(celsius > 40) celsius = 40;

Subscribers

People subscribed via source and target branches