Merge lp:~mars/launchpad/silence-pycrypto-warnings into lp:launchpad

[Māris Fogels]

Silence a pair of DeprecationWarnings from pycrypto when running under Python2.6.

Hi,

This branch silences a pair of annoying warnings in pycrypto 2.0.1 under Python2.6.

I added a new site-wide warnings hook to lp_sitecustomize.py to do this.

I will run this through ec2 test before landing the change, as it touches the site-wide configuration.

Test: bin/ec2
Pre-implementation call with: gary_poster
Lint: None

Maris

[Michael Nelson (michael.nelson)]

Hi Maris,

did you or Gary talk about the option following the deprecation warning and using hashlib instead of sha throughout lp? There's an example of a conditional import in:

lib/mailman/Mailman/Utils.py

Or temporarily suppressing the warning where it is currently used, so we don't introduce more?
http://docs.python.org/library/warnings.html#temporarily-suppressing-warnings

Also, I'm not sure how the module regex is meant to work there... at least, it doesn't work in a console:
{{{
In [1]: import warnings

In [2]: warnings.filterwarnings("ignore", category=DeprecationWarning, module="crypto")

In [3]: import sha
/usr/bin/ipython:1: DeprecationWarning: the sha module is deprecated; use the hashlib module instead
  #!/usr/bin/python

In [4]:
}}}

but this does:

{{{
In [1]: import warnings

In [2]: warnings.filterwarnings("ignore", category=DeprecationWarning, message="the sha module is deprecated")

In [3]: import sha

In [4]:
}}}

Thanks!

review: Needs Information (code)

[Michael Nelson (michael.nelson)]

> Also, I'm not sure how the module regex is meant to work there... at least, it
> doesn't work in a console:
> {{{
> In [1]: import warnings
>
> In [2]: warnings.filterwarnings("ignore", category=DeprecationWarning,
> module="crypto")

That should have been Crypto, and right, after sending one of my own branches off with bin/ec2 just now, I understand the module regex :) Never mind me.

...
>
> Thanks!

review: Approve (code)

=== modified file 'lib/lp_sitecustomize.py'
--- lib/lp_sitecustomize.py	2010-04-22 23:02:07 +0000
+++ lib/lp_sitecustomize.py	2010-06-09 21:06:30 +0000
@@ -5,15 +5,28 @@
 # buildout.cfg (see the "initialization" key in the "[scripts]" section).
 
 import os
+import warnings
+
+from bzrlib.branch import Branch
 from lp.services.mime import customizeMimetypes
 from zope.security import checker
-from bzrlib.branch import Branch
+
 
 def dont_wrap_class_and_subclasses(cls):
     checker.BasicTypes.update({cls: checker.NoProxy})
     for subcls in cls.__subclasses__():
         dont_wrap_class_and_subclasses(subcls)
 
+def silence_warnings():
+    """Silence warnings across the entire Launchpad project."""
+    # pycrypto-2.0.1 on Python2.6:
+    #   DeprecationWarning: the sha module is deprecated; use the hashlib
+    #   module instead
+    warnings.filterwarnings(
+        "ignore",
+        category=DeprecationWarning,
+        module="Crypto")
+
 def main():
     # Note that we configure the LPCONFIG environmental variable in the
     # custom buildout-generated sitecustomize.py in
@@ -26,5 +39,6 @@
     os.environ['STORM_CEXTENSIONS'] = '1'
     customizeMimetypes()
     dont_wrap_class_and_subclasses(Branch)
+    silence_warnings()
 
 main()