Merge lp:~mars/launchpad/fix-subscribers-list-484848 into lp:launchpad/db-devel

[Māris Fogels]

[Māris Fogels (mars)]

Hi,

This branch attempts to fix the Bug Subscribers layout issues encountered in Bug #484848.

I added a single CSS declaration for the subscribers list so that the icons display inline, on the correct line. This has the drawback that text wrapping doesn't work as well as it did before, but it appears to be worth the trade off to fix #484848.

We may find a better approach in the future, at which time these changes can be backed out.

Maris

[Deryck Hodge (deryck)]

Hi, mars.

Looks good. Thanks!

Not sure we need the XXX since this bug will be fixed and wrapping will never bother us, given that we truncate the lines. The comment is nice to clarify, but not sure we need the XXX.

Cheers,
deryck

review: Approve (code)

[Deryck Hodge (deryck)]

review: Approve (code)

[Martin Albisetti (beuno)]

Looks good to land, thanks for tackling this and filing the bug.

review: Approve

=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css	2009-11-21 09:12:43 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css	2009-11-23 15:25:36 +0000
@@ -956,6 +956,17 @@
 .vertical .sprite:first-line {
     line-height: 12px;
 }
+
+/* XXX: mars 2009-11-22 bug=484848
+  Override the styling in the Bug Subscribers portlet.  Trying to display
+  as inline-block is of little use, as the maximum name width is 20 characters,
+  and we are unlikely to wrap the text. Not to mention that setting the display
+  in this way breaks the icons.
+*/
+body.tab-bugs #portlet-subscribers .sprite {
+    display: inline;
+}
+
 .sprite-after {padding: 2px 18px 0 0;}
 
 /* XXX: EdwinGrubbs 2009-07-27 bug=405476