Code review comment for lp:~mars/launchpad/fix-js-unittests

Revision history for this message
Gavin Panella (allenap) wrote :

Has been renamed as Y.error(), or is it a deprecated synonym? If neither, then I'd be inclined to leave it alone; "fail" more closely matches the terminology used in the Python testing world. Y.error() sounds like it should be used when test set-up fails, not when an assertion fails.

I'm very happy to see that the 'click' simulation has been fixed (re. test_me_too.js). Figuring that one out caused me a very sweary afternoon of pain.

Thanks for doing this :)

review: Approve

« Back to merge proposal