Merge lp:~marmyshev/openlp/20_bug_1117098 into lp:openlp/2.0

Proposed by Dmitriy Marmyshev
Status: Merged
Approved by: Raoul Snyman
Approved revision: 2171
Merged at revision: 2170
Proposed branch: lp:~marmyshev/openlp/20_bug_1117098
Merge into: lp:openlp/2.0
Diff against target: 13 lines (+2/-0)
1 file modified
openlp/core/ui/maindisplay.py (+2/-0)
To merge this branch: bzr merge lp:~marmyshev/openlp/20_bug_1117098
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
matysek (community) Approve
Jonathan Corwin (community) Approve
Review via email: mp+186251@code.launchpad.net

This proposal supersedes a proposal from 2013-09-17.

Description of the change

fixed transparent display for OS X

To post a comment you must log in.
Revision history for this message
Raoul Snyman (raoul-snyman) wrote : Posted in a previous version of this proposal

Looks fine to me, but I don't have a way to test it out.

review: Approve
Revision history for this message
Jonathan Corwin (j-corwin) wrote : Posted in a previous version of this proposal

Has it been tested on Windows / Linux?

I recall having fun with transparency where fixing something on one platform had nasty side effects on others!

Revision history for this message
Tim Bentley (trb143) wrote : Posted in a previous version of this proposal

I will test tomorrow or Thursday but not before on fedora. Need to test on unity as from memory that is picky.

Revision history for this message
Jonathan Corwin (j-corwin) :
review: Approve
Revision history for this message
matysek (mzibricky) wrote :

I tested it on my osx 10.7 and this branch really fixes it.

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openlp/core/ui/maindisplay.py'
2--- openlp/core/ui/maindisplay.py 2013-03-05 17:14:17 +0000
3+++ openlp/core/ui/maindisplay.py 2013-09-18 06:52:47 +0000
4@@ -175,8 +175,10 @@
5 def setTransparency(self, enabled):
6 if enabled:
7 self.setAutoFillBackground(False)
8+ self.setStyleSheet("QGraphicsView {background: transparent; border: 0px;}")
9 else:
10 self.setAttribute(QtCore.Qt.WA_NoSystemBackground, False)
11+ self.setStyleSheet("QGraphicsView {}")
12 self.setAttribute(QtCore.Qt.WA_TranslucentBackground, enabled)
13 self.repaint()
14

Subscribers

People subscribed via source and target branches