Merge lp:~markwash/network-service/test-cleanup into lp:~rajarammallya/network-service/melange_framework

Proposed by Mark Washenberger
Status: Merged
Merged at revision: 25
Proposed branch: lp:~markwash/network-service/test-cleanup
Merge into: lp:~rajarammallya/network-service/melange_framework
Diff against target: 52 lines (+3/-12)
3 files modified
run_tests.py (+2/-1)
run_tests.sh (+1/-1)
tools/pip-requires (+0/-10)
To merge this branch: bzr merge lp:~markwash/network-service/test-cleanup
Reviewer Review Type Date Requested Status
Rajaram Mallya Approve
Review via email: mp+62069@code.launchpad.net

Description of the change

Remove seemingly unneeded dependencies from tools/pip-requires and got pep8 working a bit better after running tests.

To post a comment you must log in.
Revision history for this message
Rajaram Mallya (rajarammallya) wrote :

Thanks. We had just copied over all the pep8 stuff from glance:-)

review: Approve
Revision history for this message
Mark Washenberger (markwash) wrote :

Btw, I am working on an email to you guys if any of my merge props seem confusing at this time.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run_tests.py'
2--- run_tests.py 2011-05-09 12:53:47 +0000
3+++ run_tests.py 2011-05-24 03:33:33 +0000
4@@ -269,10 +269,11 @@
5
6
7 if __name__ == '__main__':
8+ working_dir = os.path.abspath(os.path.join("tests", "unit"))
9 c = config.Config(stream=sys.stdout,
10 env=os.environ,
11 verbosity=3,
12- workingDir=os.path.abspath(os.path.join("tests","unit")))
13+ workingDir=working_dir)
14
15 runner = MelangeTestRunner(stream=c.stream,
16 verbosity=c.verbosity,
17
18=== modified file 'run_tests.sh'
19--- run_tests.sh 2011-05-09 12:43:45 +0000
20+++ run_tests.sh 2011-05-24 03:33:33 +0000
21@@ -79,5 +79,5 @@
22 #
23 PEP8_EXCLUDE=vcsversion.py
24 PEP8_OPTIONS="--exclude=$PEP8_EXCLUDE --repeat --show-pep8 --show-source"
25-PEP8_INCLUDE="bin/* melange tests tools setup.py run_tests.py"
26+PEP8_INCLUDE="bin/* melange tests tools run_tests.py"
27 run_tests && pep8 $PEP8_OPTIONS $PEP8_INCLUDE || exit 1
28
29=== modified file 'tools/pip-requires'
30--- tools/pip-requires 2011-05-12 09:25:25 +0000
31+++ tools/pip-requires 2011-05-24 03:33:33 +0000
32@@ -1,20 +1,10 @@
33-greenlet>=0.3.1
34 SQLAlchemy>=0.6.3
35 pep8==0.5.0
36-pylint==0.19
37-anyjson
38 eventlet>=0.9.12
39 PasteDeploy
40 routes
41 webob
42 webtest
43-wsgiref
44 nose
45-sphinx
46-argparse
47-mox==0.5.0
48-swift
49--f http://pymox.googlecode.com/files/mox-0.5.0.tar.gz
50 sqlalchemy-migrate>=0.6
51-bzr
52 netaddr

Subscribers

People subscribed via source and target branches