Merge lp:~markuz/gwibber/trunk into lp:~gwibber-committers/gwibber/trunk.merge.backup

Proposed by markuz
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp:~markuz/gwibber/trunk
Merge into: lp:~gwibber-committers/gwibber/trunk.merge.backup
Diff against target: None lines
To merge this branch: bzr merge lp:~markuz/gwibber/trunk
Reviewer Review Type Date Requested Status
Ken VanDine Needs Fixing
Review via email: mp+11027@code.launchpad.net
To post a comment you must log in.
Revision history for this message
markuz (markuz) wrote :

Try to fix bug # 407733

Revision history for this message
markuz (markuz) wrote :
Revision history for this message
Ken VanDine (ken-vandine) wrote :

I tried this out, it does fix the rendering of some of the icons, at least they aren't huge. But it makes the other icons a bit bigger than they were and look fuzzy. Thanks

review: Needs Fixing

Unmerged revisions

401. By markuz

* Try to fix bug #407733 https://bugs.launchpad.net/gwibber/+bug/407733
  by setting the icons to 22x22 px.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/gwui.py'
2--- gwibber/gwui.py 2009-09-01 04:42:03 +0000
3+++ gwibber/gwui.py 2009-09-02 00:28:39 +0000
4@@ -108,8 +108,9 @@
5 aname = (acct["username"] or "None").capitalize()
6 apath = "/gwibber/%s/%s" % (acct["protocol"], acct["id"])
7 aicon = resources.get_ui_asset("icons/%s.png" % acct["protocol"])
8-
9- ti = self.append(None, [aname, apath, acct["id"], None, pbfile(aicon), None, None])
10+ pixbuf = pbfile(aicon)
11+ pixbuf = pixbuf.scale_simple(22, 22, gtk.gdk.INTERP_BILINEAR)
12+ ti = self.append(None, [aname, apath, acct["id"], None, pixbuf, None, None])
13
14 tree_features = [self.features[f] for f in
15 self.protocols[acct["protocol"]]["features"]
16@@ -120,7 +121,10 @@
17 apath = "/gwibber/%s/%s/%s" % (acct["protocol"], acct["id"], f["stream"])
18 aname = f["stream"].capitalize()
19 aicon = resources.icon(f["icon"], use_theme=False) or resources.get_ui_asset("icons/%s.png" % f["icon"])
20- self.append(ti, [aname, apath, acct["id"], f["name"], pbfile(aicon), None, None])
21+ pixbuf = pbfile(aicon)
22+ pixbuf = pixbuf.scale_simple(22, 22, gtk.gdk.INTERP_BILINEAR)
23+
24+ self.append(ti, [aname, apath, acct["id"], f["name"], pixbuf, None, None])
25
26 return ti
27
28@@ -152,6 +156,7 @@
29 for n, i in toplevel.items():
30 icf = resources.icon(i, use_theme=False) or resources.get_ui_asset("icons/%s.png" % i)
31 icon = pbfile(icf)
32+ icon = icon.scale_simple(22, 22, gtk.gdk.INTERP_BILINEAR)
33 self.append(None, [n.capitalize(), n, None, None, icon, None, None])
34
35 for acct in self.accounts: self.add_account(acct)

Subscribers

People subscribed via source and target branches

to all changes: